[advanced-reboot] Handle logs on tmpfs for all new platforms #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingwang-ms
approved these changes
Jul 24, 2023
|
The change looks good to me. |
There is an OR check for logs on tmpfs. The check for platform is needed when base image does not have logs on tmpfs (eg., 201911), and target does (202205). |
|
@vaibhavhd PR conflicts with 202205 branch |
|
@vaibhavhd PR conflicts with 202012 branch |
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…et#9094) Fix the tests failing on newly addded platforms where logs are moved to tmpfs. Related PR: sonic-net/sonic-buildimage#15077 Fixes: sonic-net/sonic-buildimage#15895 This change updates the check from hwsku match to platform match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Tests failing on newly addded platforms where logs are moved to tmpfs.
Related PR: sonic-net/sonic-buildimage#15077
Fixes: sonic-net/sonic-buildimage#15895
This change updates the check from hwsku match to platform match
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation