[dhcp_relay] More detailed crafting and strict testing of OFFER and ACK packets #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Jun 5, 2019
yxieca
pushed a commit
that referenced
this pull request
Jun 13, 2019
stepanblyschak
pushed a commit
to stepanblyschak/sonic-mgmt
that referenced
this pull request
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request sonic-net/sonic-buildimage#2919 which was merged into the 201811 branch sonic-buildimage will cause the dhcp_relay test to erroneously fail, due to minor changes in the relayed OFFER and ACK packets. A similar pull request is now open against the master branch of sonic-buildimage here: sonic-net/sonic-buildimage#2946. This change will ensure the dhcp_relay test works as expected after the aforementioned changes. This PR should be merged into master and cherry-picked into 201811.