[sfputil] Make SfpUtilHelper.get_physical_to_logical noexcept as in SfpUtilBase #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboykox
force-pushed
the
fix-sfputilhelper
branch
from
f07ef06
to
a849c56
Compare
vboykox
changed the title
Make SfpUtilHelper.get_physical_to_logical noexcept as in SfpUtilBase Signed-off-by: Volodymyr Boyko <[email protected]>
msosyak
approved these changes
Jun 22, 2020
vboykox
force-pushed
the
fix-sfputilhelper
branch
2 times, most recently
from
0e5a100
to
4b13484
Compare
jleveque
approved these changes
Jun 27, 2020
abdosi
pushed a commit
that referenced
this pull request
Jul 8, 2020
…fpUtilBase (#96) The SfpUtil interface used in xcvrd expects get_physical_to_logical to return None in the case of unknown port: https://github.com/Azure/sonic-platform-daemons/blob/master/sonic-xcvrd/scripts/xcvrd#L906 Note SfpUtilBase implementation already conforms the interface in xcvrd: https://github.com/Azure/sonic-platform-common/blob/master/sonic_platform_base/sonic_sfp/sfputilbase.py#L603 Signed-off-by: Volodymyr Boyko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SfpUtil interface used in xcvrd expects get_physical_to_logical to return None in the case of unknown port:
https://github.com/Azure/sonic-platform-daemons/blob/master/sonic-xcvrd/scripts/xcvrd#L906
Note SfpUtilBase implementation already conforms the interface in xcvrd:
https://github.com/Azure/sonic-platform-common/blob/master/sonic_platform_base/sonic_sfp/sfputilbase.py#L603