Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pcied daemon failure #91

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Fix pcied daemon failure #91

merged 1 commit into from
Sep 9, 2020

Conversation

bratashX
Copy link
Contributor

@bratashX bratashX commented Sep 9, 2020

Signed-off-by: Petro Bratash [email protected]

Fix pcied daemon error:

Traceback (most recent call last):
  File "/usr/local/bin/pcied", line 144, in <module>
    main()
  File "/usr/local/bin/pcied", line 141, in main
    pcied.run()
  File "/usr/local/bin/pcied", line 125, in run
    self.check_pcie_devices()
  File "/usr/local/bin/pcied", line 79, in check_pcie_devices
    if err:
UnboundLocalError: local variable 'err' referenced before assignment

@bratashX
Fix pcied daemon failure
e481870 
Signed-off-by: Petro Bratash <[email protected]>
@bratashX
Copy link
Contributor Author

bratashX commented Sep 9, 2020

@akokhan @sujinmkang , please review.

@sujinmkang sujinmkang merged commit 0969202 into sonic-net:master Sep 9, 2020
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
@Junchao-Mellanox
[chassis_base] Add platform API support for system LED (sonic-net#91)
9f3be44 
Why I did this?

To support system health feature, we need get/set system LED status.

How I did this?

Add 2 new platform API to chassis_base.py for vendor to implement:
- set_status_led
- get_status_led
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akokhan akokhan akokhan approved these changes

@sujinmkang sujinmkang sujinmkang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bratashX @akokhan @sujinmkang