Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer 2 Forwarding Enhancements #510

Merged
merged 22 commits into from
Nov 27, 2019
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions vslib/src/sai_vs_fdb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ sai_status_t internal_vs_flush_fdb_entries(
* response causes syncd to delete ASIC_DB entries in a loop and
* stuck for long time when a large number of FDB entries are present.
*/
#if 0

/*
* We can have 3 attributes (so far) to flush by:
* - entry type
Expand Down Expand Up @@ -274,7 +274,12 @@ sai_status_t internal_vs_flush_fdb_entries(

SWSS_LOG_NOTICE("generating fdb flush notifications");

/* notification has been sent for individual mac delete, so
* not sending the bulk flush notification
*/
#if 0
sai_fdb_event_notification_fn ntf = (sai_fdb_event_notification_fn)attr.value.ptr;
#endif

sai_fdb_event_notification_data_t data;
sai_attribute_t attrs[2];
Expand Down Expand Up @@ -313,11 +318,16 @@ sai_status_t internal_vs_flush_fdb_entries(
attrs[0].value.s32 = SAI_FDB_ENTRY_TYPE_STATIC;

meta_sai_on_fdb_event(1, &data); // update metadata


/* notification has been sent for individual mac delete, so
* not sending the bulk flush notification
*/
#if 0
if (ntf != NULL)
{
ntf(1, &data);
}
#endif
}

if (dynamic_fdbs.size() > 0)
Expand All @@ -328,18 +338,21 @@ sai_status_t internal_vs_flush_fdb_entries(
attrs[0].value.s32 = SAI_FDB_ENTRY_TYPE_DYNAMIC;

meta_sai_on_fdb_event(1, &data); // update metadata


/* notification has been sent for individual mac delete, so
* not sending the bulk flush notification
*/
#if 0
anilkpandey marked this conversation as resolved.
Show resolved Hide resolved
if (ntf != NULL)
{
ntf(1, &data);
}

#endif
SWSS_LOG_NOTICE("1");
}

// TODO: we can add config entry to send notifications 1 by 1 as option to consolidated

#endif
return SAI_STATUS_SUCCESS;
}

Expand Down