Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling Framework: Syncd Changes to report SAI failures #523

Closed
wants to merge 1 commit into from

Conversation

sivamukka
Copy link

@sivamukka sivamukka commented Oct 18, 2019

Error handling framework is responsible for notifying ASIC/SAI programming failures to the applications.

Changes in syncd includes:

  • Capture the SAI return codes
  • Send the return codes to OrchAgent through a channel
  • Provision to enable or disable the notification to OrchAgent

Functional specification PR:
sonic-net/SONiC#391

Dependent PRs:
sonic-net/sonic-swss-common#309
sonic-net/sonic-utilities#709

Related PRs:
sonic-net/sonic-utilities#666
sonic-net/sonic-swss#1100

Signed-off-by: Siva Mukka ([email protected])

- Capture the SAI return codes
- Send the return codes to OrchAgent through a channel
- Provision to enable or disable the notification to OA
{
SWSS_LOG_ERROR("attr: %s: %s", fvField(v).c_str(), fvValue(v).c_str());
internal_syncd_api_send_response(api, status);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the else case is redundant, 'internal_syncd_api_send_response' is called at the beginning of the previous 'else' layer.

@kcudnik
Copy link
Collaborator

kcudnik commented Jul 6, 2021

closing this as obsolete, code shifted to cpp, and we already introduced synchronous mode where OA will get correct error message with status code

@kcudnik kcudnik closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants