Update transceiver info DB key names #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Jul 14, 2020
qiluo-msft
reviewed
Jul 14, 2020
| HARDWARE_REVISION = b"hardware_rev" | ||
| SERIAL_NUMBER = b"serial" | ||
| MANUFACTURE_NAME = b"manufacturer" | ||
| MODEL_NAME = b"model" |
There was a problem hiding this comment.
It is better to move into a common place and shared with the repo sonic-platform-common.
There was a problem hiding this comment.
It would prevent the need for dependent changes like this in the future. Please feel free to open an issue.
There was a problem hiding this comment.
Could you clarify "prevent the need for dependent changes like this in the future"? I think it will make it easier.
There was a problem hiding this comment.
This PR was necessary because the key names were updated in sonic-platform-common. If the two repos shared a common source for the data, this PR would not be necessary.
qiluo-msft
approved these changes
Jul 14, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 4, 2020
Update transceiver info DB key names to align with recent change here: sonic-net/sonic-platform-common#97
kktheballer
pushed a commit
to kktheballer/sonic-snmpagent
that referenced
this pull request
Oct 1, 2020
Update transceiver info DB key names to align with recent change here: sonic-net/sonic-platform-common#97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update transceiver info DB key names to align with recent change here: sonic-net/sonic-platform-common#97