Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fabric monitoring tables definitions. #808

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Add fabric monitoring tables definitions. #808

merged 10 commits into from
Sep 25, 2023

Conversation

jfeng-arista
Copy link
Contributor

Add fabric monitoring table names in a common location, as they are utilized in multiple files associated with the fabric monitoring feature.

@jfeng-arista jfeng-arista mentioned this pull request Jul 31, 2023
Merged
@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

The failure was

2023-07-28T22:55:52.2381925Z ==================================== ERRORS ====================================
2023-07-28T22:55:52.2382365Z ___________ ERROR at setup of TestAcl.test_AclTableCreationDeletion ____________
2023-07-28T22:55:52.2382548Z
2023-07-28T22:55:52.2383106Z tp = <class 'AssertionError'>, value = None, tb = None
2023-07-28T22:55:52.2383225Z
2023-07-28T22:55:52.2387164Z def reraise(tp, value, tb=None):
2023-07-28T22:55:52.2387402Z try:
2023-07-28T22:55:52.2387618Z if value is None:
2023-07-28T22:55:52.2387832Z value = tp()
2023-07-28T22:55:52.2388083Z if value.traceback is not tb:
2023-07-28T22:55:52.2388615Z > raise value.with_traceback(tb)

@arlakshm
Copy link
Contributor

/Azp Azure.sonic-swss-common

@azure-pipelines
Copy link

Command 'Azure.sonic-swss-common' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft
qiluo-msft reviewed Aug 4, 2023
View reviewed changes
common/schema.h Outdated Show resolved Hide resolved
@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui
Copy link

rlhui commented Aug 18, 2023

Is this a code refactoring only or it's to actually fix any bug? Thanks.

@jfeng-arista
Copy link
Contributor Author

These are the table defination for fabric link monitoring feature, the other code will depend on these tables

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

it failed with

In file included from dash/dashaclorch.h:19,
from orchdaemon.h:49,
from main.cpp:25:
dash/dashorch.h:21:10: fatal error: dash_api/appliance.pb.h: No such file or directory
21 | #include "dash_api/appliance.pb.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

It seems not related to this change

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test_NeighborAddRemoveIpv6LinkLocal failed (1 runs remaining out of 2).
<class 'AssertionError'>
assert 3 == 4
-3
+4
it looks like not related to this change

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test_NeighborAddRemoveIpv6LinkLocal failed (1 runs remaining out of 2).
<class 'AssertionError'>
assert 3 == 4
-3
+4
[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_ipv6_link_local.py:63>]

The failure not related to this change

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm arlakshm merged commit b0f148e into sonic-net:master Sep 25, 2023
14 checks passed
@jfeng-arista jfeng-arista mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@arlakshm arlakshm arlakshm approved these changes

Assignees

@jfeng-arista jfeng-arista

Labels
None yet
Projects
SONiC Chassis
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jfeng-arista @mssonicbld @arlakshm @rlhui @qiluo-msft