Skip to content

Commit

Permalink
[systemport]System port pvid setting error fix
Browse files Browse the repository at this point in the history
Signed-off-by: vedganes <[email protected]>

While adding system port as member for a system port channel, pvid is
set. Since pvid setting is not applicable for systemports in remote
asics, SAI returns faiure. This results in display of error.
setPortPvid() api is modified to skip setting the pvid for system ports
and an INFO is displayed.
  • Loading branch information
vedganes committed Feb 2, 2021
1 parent 849d92e commit 8d9effc
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions orchagent/portsorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1380,6 +1380,12 @@ bool PortsOrch::setPortPvid(Port &port, sai_uint32_t pvid)
return true;
}

if(port.m_type == Port::SYSTEM)
{
SWSS_LOG_INFO("pvid setting for system port %s is not applicable", port.m_alias.c_str());
return true;
}

if (port.m_rif_id)
{
SWSS_LOG_ERROR("pvid setting for router interface %s is not allowed", port.m_alias.c_str());
Expand Down

0 comments on commit 8d9effc

Please sign in to comment.