Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] vs tests in TestAcl in test_acl.py have dependency on each other #1154

Closed
daall opened this issue Dec 18, 2019 · 0 comments · Fixed by #1378
Closed

[testing] vs tests in TestAcl in test_acl.py have dependency on each other #1154

daall opened this issue Dec 18, 2019 · 0 comments · Fixed by #1378
Assignees
@daall
Labels
Cleanup 💧 Testing

Comments

@daall
Copy link
Contributor

daall commented Dec 18, 2019

Currently all the test cases in the TestAcl class in test_acl.py rely on test_AclTableCreation or test_V6AclTableCreation for the tables that they need. This means that individual test cases in TestAcl cannot be run on their own.

ACL table creation/deletion should be added to the TestAcl class as a fixture so that the creation/deletion is still automatic, but individual test cases can be run during feature development.
@daall daall self-assigned this Dec 18, 2019
@daall daall mentioned this issue Dec 18, 2019
Merged
@daall daall mentioned this issue Aug 5, 2020
Merged
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this issue Mar 1, 2023
@prasanna-cls
The meta_sai_validate_fdb_entry() validates the input FDB entry for t…
4e24c77 
…he (sonic-net#1154)

set/remove operation.
When there is no matching FDB entry found in the database, then an incorrect
SAI error code (SAI_STATUS_INVALID_PARAMETER) is returned.
As a port of this fix, the correct SAI error return code (SAI_STATUS_ITEM_NOT_FOUND)
is returned.
This Return code can be used by the callers to take approprite actions, if the FDB entry is
indeed not available during the set/remove operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daall daall

Labels
Cleanup 💧 Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dvs_acl] Refactor and document dvs_acl library daall/sonic-swss
1 participant
@daall