Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vs_test]fix fdb test failed randomly #1118

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

tylerlinp
Copy link
Contributor

What I did

  1. Change test_FdbAddedAfterMemberCreated not to assert the count of entries but to check the existance of entry added by itself, because other entry may be learned after flush. The former test case does't clean the config, that makes more chance to learn fdb entry.
  2. Fix the bug is_fdb_entry_exists didn't match key. Add a function get_vlan_oid to change vlanid to bvid. Change mac format to match in asic_db.

Why I did it
fdb test failed often

How I verified it
pass vs tests

Details if related

@kcudnik
Copy link
Contributor

kcudnik commented Nov 5, 2019

thanks for fixing this, issue root cause was that virtual switch was learning other fdb entries during tests, and number of entries could be different each time

@lguohan lguohan merged commit 5604566 into sonic-net:master Nov 5, 2019
@tylerlinp tylerlinp deleted the fdb_test branch November 27, 2019 07:12
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
… fields are not updated properly for the mac #11503Update NotificationProcessor.cpp (sonic-net#1118)

In case of a mac move event, remove the existing FDB entry from ASIC DB first and then set the new one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants