Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for NAT lgtm alerts #1320

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fixes for NAT lgtm alerts #1320

merged 1 commit into from
Jun 17, 2020

Conversation

AkhileshSamineni
Copy link
Contributor

This PR fixes all NAT lgtm erros (https://github.com/Azure/sonic-buildimage/issues/4698)

Signed-off-by: Akhilesh Samineni [email protected]

@AkhileshSamineni
Fixes for NAT lgtm alerts
c17b6f3 
 Signed-off-by: Akhilesh Samineni <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2020

This pull request fixes 3 alerts when merging c17b6f3 into a3a010a - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Resource not released in destructor
  • 1 for Comparison where assignment was intended

@lguohan lguohan requested review from rlhui and qiluo-msft June 17, 2020 18:46
@qiluo-msft qiluo-msft merged commit 0784502 into sonic-net:master Jun 17, 2020
@AkhileshSamineni
Copy link
Contributor Author

Need these changes for 201911 branch as well.

@lguohan lguohan mentioned this pull request Jun 25, 2020
Closed
@abdosi
Copy link
Contributor

abdosi commented Jul 8, 2020

@AkhileshSamineni Cherry-pick has conflict. Raise separate PR for 201911

cc @rlhui

@AkhileshSamineni AkhileshSamineni mentioned this pull request Aug 10, 2020
Merged
@AkhileshSamineni
Copy link
Contributor Author

@abdosi Raised new PR #1391 for it.

rlhui pushed a commit that referenced this pull request Dec 16, 2020
@AkhileshSamineni
[201911] Fixes for NAT lgtm alerts (#1391)
bb1b351 
This PR is similar as #1320 which is merged on master branch.

Signed-off-by: Akhilesh Samineni [email protected]
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@gechiang
Added show ip/v6 route summary support for multi-asic platform (sonic…
d63d11d 
…-net#1320)

* Added show ip/v6 route summary support for multi-asic platform by making any additional parameter handling other than specific route cases or json format to be handled by the corresponding namespace FRR directly.
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Oct 12, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
0f699aa 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
@huseratgithub huseratgithub mentioned this pull request Oct 12, 2023
Merged
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Oct 30, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
1c27125 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Oct 31, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
80cac39 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Nov 20, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
8dca8fa 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Nov 23, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
a1697c7 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Dec 1, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
55a8720 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Dec 4, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
8634ab4 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Dec 15, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
55f201a 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Dec 18, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation
277ba28 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Dec 20, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
49aea97 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Dec 21, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
67dba48 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Dec 29, 2023
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
fb53d0a 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Jan 12, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
986ea3a 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Jan 25, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
515c284 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Feb 20, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
1f1e17c 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Feb 22, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
b36d682 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Feb 26, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
3736534 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Mar 16, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
59cd6b1 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Mar 19, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
9487c3f 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
huseratgithub added a commit to CentecNetworks/sonic-swss that referenced this pull request Apr 1, 2024
@huseratgithub
[orchagent] TWAMP Light orchagent implementation. (sonic-net#2927)
c467ee8 
- What I did
Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net#1320).

- Why I did it
Part of the TWAMP Light feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Xiaodong Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@rlhui rlhui Awaiting requested review from rlhui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkhileshSamineni @abdosi @qiluo-msft @rlhui