swss: gearsyncd should return 0 on exit #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changes made to supervisord conf require gearsyncd to return 0 otherwise restarts are performed, fail, and swss docker exits * originally, gearsyncd did not exit, and if it did, 1 exit code was returned to indicate failure. We converted this to do its job and exit, but did not correct the exit code. * prior state was not a problem until changes that yet to merge for sonic-buildimage supervisord conf made returning a 1 problematic. HLD is located at https://github.com/Azure/SONiC/blob/b817a12fd89520d3fd26bbc5897487928e7f6de7/doc/gearbox/gearbox_mgr_design.md Signed-off-by: [email protected]
|
@jleveque this is going to be required for supervisord conf changes in pull 4851 to work. |
jleveque
suggested changes
Aug 4, 2020
jleveque
approved these changes
Aug 4, 2020
|
Retest vs please |
1 similar comment
|
Retest vs please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Fixed int stat with portchannel
* Replace N/A with None
Fixed crash of "show int status" command when there are portchannels in system.
Traceback (most recent call last):
File "/usr/local/bin/intfutil", line 521, in <module>
main()
File "/usr/local/bin/intfutil", line 513, in main
interface_stat.display_intf_status()
File "/usr/local/bin/intfutil", line 354, in display_intf_status
self.get_intf_status()
File "/usr/local/lib/python3.7/dist-packages/utilities_common/multi_asic.py", line 137, in wrapped_run_on_all_asics
func(self, *args, **kwargs)
File "/usr/local/bin/intfutil", line 435, in get_intf_status
self.portchannel_speed_dict = po_speed_dict(self.po_int_dict, self.db)
File "/usr/local/bin/intfutil", line 249, in po_speed_dict
interface_speed = '{}G'.format(interface_speed[:-3])
TypeError: 'NoneType' object is not subscriptable
Signed-off-by: d-dashkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restarts are performed, fail, and swss docker exits
to indicate failure. We converted this to do its job and exit, but did not
correct the exit code.
sonic-buildimage supervisord conf made returning a 1 problematic.
What I did
change exit code for gearsyncd to 0 from 1
Why I did it
for compatibility with supervisord.conf. Not to mention, processes should return 0 on success.
How I verified it
Local build.
HLD is located at https://github.com/Azure/SONiC/blob/b817a12fd89520d3fd26bbc5897487928e7f6de7/doc/gearbox/gearbox_mgr_design.md
Signed-off-by: [email protected]