Sflow fixes during DEL processing #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wendani , please review |
wendani
approved these changes
Sep 4, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 19, 2020
Co-authored-by: dgsudharsan <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…et#1427) Refactored code in neighbor_advertiser script and used mock module to unittesting
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Update SAI submodule v1.9 with the following fixes 7594e53 (HEAD, origin/v1.9) Skip brcm teardown assertion (sonic-net#1423) (sonic-net#1428) 0c33f4a [FIX]Fix the circular reference issue when build sai header py (sonic-net#1427) 7e0fc24 Add support for building under Doxygen 1.9.1 (sonic-net#1414) (sonic-net#1424) 8ecf3ef [Fix]Correct enum check on branch 1.9 (sonic-net#1418) e2b2f39 Add Thrift 0.14.1 compatibility (sonic-net#1403) (sonic-net#1416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed SFLOW handling in the DEL path. Below issues reported
#1012 (comment)
#1012 (comment)
Why I did it
Fixed the DEL sequence in the handling of sflow global and sflow interface all commands
How I verified it
Execute redis-cli -n 4 del "SFLOW|global"
The above command should remove the local level entry along with global entries. (Earlier local interface level entries are not removed)
redis-cli -n 4 del "SFLOW|global"
redis-cli -n 4 del "SFLOW_SESSION|all"
redis-cli -n 0 keys SFLOW
(empty array)
(Earlier the above command was listing all the entries)
Details if related