Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orchagent]: Remove updating APP_DB port oper_status logic from orchagent #192

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Apr 16, 2017

Signed-off-by: Shuotian Cheng [email protected]

@stcheng
Copy link
Contributor Author

stcheng commented Apr 16, 2017

This is to address the issue sonic-net/sonic-buildimage#456.

The logic is already integrated in portsyncd which will update the oper_stauts of a port once the port changes its oper_status.

@stcheng stcheng self-assigned this Apr 16, 2017
@stcheng
Copy link
Contributor Author

stcheng commented Apr 19, 2017

it is better to use orchagent to update the oper_status instead of using portsyncd
however, orchagent only gets oper_status of front panel ports notification from ASIC
vlan and port channel oper_status should still be updated from portsyncd

…s in portsyncd

- Front panel ports' oper_status should be notified from the SAI instead of getting
  it from kernel via portsyncd. Thus in this commit, oper_status is removed from the
  portsyncd.

- VLAN and LAG oper_status on the contrary need to be updated from the protocol daemon,
  the kernel and the teamd.

Signed-off-by: Shuotian Cheng <[email protected]>
@stcheng
Copy link
Contributor Author

stcheng commented Apr 19, 2017

root@str-s6000-acs-11:/home/admin# ifdown Ethernet8
root@str-s6000-acs-11:/home/admin# redis-cli
127.0.0.1:6379> hgetall PORT_TABLE:Ethernet8
 1) "lanes"
 2) "37,38,39,40"
 3) "alias"
 4) "fortyGigE0/8"
 5) "admin_status"
 6) "down"
 7) "mtu"
 8) "1500"
 9) "oper_status"
10) "down"
root@str-s6000-acs-11:/home/admin# ifup Ethernet8
device Ethernet8 is already a member of a bridge; can't enslave it to bridge Vlan1000.
root@str-s6000-acs-11:/home/admin# redis-cli
127.0.0.1:6379> hgetall PORT_TABLE:Ethernet8
 1) "lanes"
 2) "37,38,39,40"
 3) "alias"
 4) "fortyGigE0/8"
 5) "admin_status"
 6) "up"
 7) "mtu"
 8) "1500"
 9) "oper_status"
10) "up"

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the commit message?

@stcheng
Copy link
Contributor Author

stcheng commented Apr 19, 2017

commit message:

- Front panel ports' oper_status should be notified from the SAI instead of getting
  it from kernel via portsyncd. Thus in this commit, oper_status is removed from the
  portsyncd.

- VLAN and LAG oper_status on the contrary need to be updated from the protocol daemon,
  the kernel and the teamd.

@stcheng stcheng merged commit 93dd3e9 into sonic-net:master Apr 19, 2017
@stcheng stcheng deleted the oper_status branch April 19, 2017 23:27
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
* Add support for logrotate in sairedis

* Fix attribute id access

* Fix logrotate variable name

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants