Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[orchagent]: Create the switch with source MAC address #253

Merged
merged 1 commit into from
Jul 15, 2017
Merged

[orchagent]: Create the switch with source MAC address #253

merged 1 commit into from
Jul 15, 2017

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Jul 14, 2017

  • Instead of creating the switch and later setting the source MAC address,
    use the source MAC address as an attribute to create the switch.

  • Move corresponding switch attribute code to above the switch creation.

lguohan
lguohan reviewed Jul 14, 2017
View reviewed changes
orchagent/main.cpp
{
status = sai_switch_api->get_switch_attribute(gSwitchId, 1, &attr);
if (status != SAI_STATUS_SUCCESS)
{
SWSS_LOG_ERROR("Failed to get MAC address from switch %d", status);
SWSS_LOG_ERROR("Failed to get MAC address from switch, rv:%d", status);
exit(EXIT_FAILURE);
}
else
{
gMacAddress = attr.value.mac;
}
Copy link
Contributor

@lguohan lguohan Jul 14, 2017 •
edited by stcheng
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do not have switchid yet, you need to move this after create_switch. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

In reply to: 127554898 [](ancestors = 127554898)

lguohan
lguohan requested changes Jul 14, 2017
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_switch_api not in correct place.

@lguohan
Copy link
Contributor

lguohan commented Jul 14, 2017 •
edited
Loading 

    status = sai_switch_api->set_switch_attribute(gSwitchId, &attr);

you need to create_switch first. #ByDesign

Refers to: orchagent/main.cpp:179 in 75806d0. [](commit_id = 75806d0, deletion_comment = False)

@stcheng
Copy link
Contributor Author

stcheng commented Jul 14, 2017 

    status = sai_switch_api->set_switch_attribute(gSwitchId, &attr);

this is redis attributes, no need to create the switch first. please see above comments by Kamil.

In reply to: 315475884 [](ancestors = 315475884)

Refers to: orchagent/main.cpp:179 in 75806d0. [](commit_id = 75806d0, deletion_comment = False)

@lguohan
Copy link
Contributor

lguohan commented Jul 14, 2017 

    status = sai_switch_api->set_switch_attribute(gSwitchId, &attr);

should mark as by design. won't fix means acknowledge it is a bug.

In reply to: 315479635 [](ancestors = 315479635,315475884)

Refers to: orchagent/main.cpp:179 in 75806d0. [](commit_id = 75806d0, deletion_comment = False)

[orchagent]: Create the switch with source MAC address
514b652 
- Instead of creating the switch and later setting the source MAC address,
  use the source MAC address as an attribute to create the switch.

- Move corresponding switch attribute code to above the switch creation.
@stcheng stcheng merged commit cf92ed9 into sonic-net:v1.0.1 Jul 15, 2017
@stcheng stcheng deleted the main branch July 15, 2017 04:51
praveen-li pushed a commit to praveen-li/sonic-swss that referenced this pull request Aug 24, 2020
Merge remote-tracking branch 'msft_github/master'
63dbfde 
* msft_github/master:
  [swssconfig]: Update Mellanox buffer profile template to work with an incomplete minigraph (sonic-net#332)
  [portsyncd]: Remove deprecated sample file port_config.ini (sonic-net#330)
  [portsyncd]: Remove unused LAG related tables (sonic-net#329)
  [tunnelorch]: Minor comment update
  [aclorch]: Fix crashing when removing ACL table that has associated ACL rules (sonic-net#322)
  [pfcwdorch]: Initial support (sonic-net#317)
  [swssconfig]: Update buffer profile template to work with CONF_DB (sonic-net#319)
  [aclorch]: Refactor doAclTableTask and doAclRuleTask (sonic-net#318)
  [swssconfig]: Add Mellanox PG buffer profiles based on port configuration (sonic-net#301)
  [switchorch]: Add SwitchOrch to deal with switch attributes changes (sonic-net#314)
  [github]: Update pull request template comments
  [github]: Add pull request template (sonic-net#313)
  Optimize orch performance by pops() (sonic-net#312)
  Refactor TableConsumable (sonic-net#291)
  [buffer]: Remove failed tasks from the m_toSync queue (sonic-net#308)
  [qos]: Remove failed tasks from the m_toSync queue (sonic-net#306)
  [aclorch]: Add match TC support for ACL rule (sonic-net#302)
  [orchagent]: Set log recording directory before enable recording (sonic-net#300)
  [orchagent]: Remove duplicate SwSS recording file set code (sonic-net#298)
  Fix port speed validation (sonic-net#288)
  [fdborch]: Fix FdbOrch code to work upon SAI v1.0 (sonic-net#284)
  [config]: Add BGPv6 COPP in 00-copp.config.json (sonic-net#281)
  [aclorch]: Fix match DSCP attribute value mask length to 0x3F
  [mirrororch]: Set the VLAN header only when the packet is mirrored to a VLAN (sonic-net#282)
  [swssconfig]: Log errors instead of throwing exception when file open fails (sonic-net#277)
  [aclorch]: Remove wrong table attribute (sonic-net#280)
  [aclorch]: Fix remove_acl_counter function to remove the counter (sonic-net#274)
  [copporch]: Add SAI_HOSTIF_TRAP_ATTR_TRAP_PRIORITY support and refactor code (sonic-net#270)
  [mirrororch]: Add SAI_MIRROR_SESSION_ATTR_VLAN_HEADER_VALID (sonic-net#269)
  [bufferorch]: Add SAI_BUFFER_PROFILE_THRESHOLD_MODE_* (sonic-net#271)
  [aclorch]: Minor logs fix
  [orchagent]: Update recording file name to swss.rec
  [Make]: Fix type conversions and add more warnings (sonic-net#267)
  [aclorch]: Fix ACL table group attribute type issue (sonic-net#268)
  [portsorch]: Update default bridge port removal logic (sonic-net#263)
  [routeorch]: Need to set drop route next hop ID to NULL (sonic-net#261)
  [portsorch]: Remove SAI_PORT_ATTR_BIND_MODE (sonic-net#262)
  [portsorch]: Create a bridge port with admin status set to UP (sonic-net#259)
  Revert "[portsorch]: Set port bind mode after adding VLAN member" (sonic-net#258)
  [orchagent]: Temporarily fix pre-allocated bridge_port_list size (sonic-net#256)
  [saihelper]: Create initSaiRedis function and put related code inside it (sonic-net#254)
  [portsorch]: Set port bind mode after adding VLAN member (sonic-net#251)
  [orchagent]: Create the switch with source MAC address (sonic-net#253)
  [copporch]: Add UDLD entry in COPP (sonic-net#252)
  [orchagent]: Support LAG/VLAN with SAI 1.0 (sonic-net#250)
  use vlan oid instead of vlan id (sonic-net#247)
  Fix getBridgePort: handle non existing bridge_port_id
  Integration for SAI v1.0.1
  Remove vlan member before removing bridge port
  Fix SAI functional calls
  Fix: store bridge ports at initialization
  Refactor vector<attr>
  Resolve review comments
  Implement bridge port in portsorch
  Fix initSystemAclTable: bind system ACL to each port
  Refactor: port owns acl table group
  Resolve code review comments
  Resolve code review comments
  Adpat SAIv1.0 headers and fix compilation errors
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@zhenggen-xu @jleveque
Fix sfputil/psuutil issues due to dependencies on minigraph (sonic-ne…
9087d5f 
…t#253)
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@kcudnik
[252] Create hostif fails on vslib when no tap device is used (sonic-…
9658f75 
…net#253)
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023
@prgeor
[build] Update python-wheel target path to latest in master (sonic-ne…
8e06e7f 
…t#253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stcheng @lguohan @msftclas