[routeorch]: Need to set drop route next hop ID to NULL #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In orchagent, route's next hop packet action is set to DROP. But the previous next hop object is still referenced by the route. This will cause the next hop group removal failure. Reset the drop route next hop ID to NULL to remove the reference for the previous next hop object.
|
After the route is set back to DROP, the next hop ID is set to 0x0. |
|
deprecated since #261 is already merged. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
…t#260) Signed-off-by: vaibhav-dahiya [email protected] Description Currently is_link_active API was broken because it was not using the target param in the routine to give back the correct link_status of ecah side. With this change it gives the correct result. Motivation and Context Required for MUX_CABLE_INFO table in streaming telemetry if the cable is disconnected or the link is down. redis-cli -n 6 hgetall "MUX_CABLE_INFO|Ethernet16" " 9) "link_status_self" 10) "down" 11) "link_status_peer" 12) "up" 13) "link_status_nic" 14) "up" How Has This Been Tested? Tested on actual Arista7050cx3 testbed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In orchagent, route's next hop packet action is set to DROP. But the previous
next hop object is still referenced by the route. This will cause the next
hop group removal failure.
Reset the drop route next hop ID to NULL to remove the reference for the
previous next hop object.