Explicitly initialize two local variables to 0 #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 12 (in Debian Bookworm) claims that on armhf targets, the `lower` local variable in `Orch::generateIdListFromMap` could potentially be used uninitialized a few lines later when it's being converted to a string. I don't see how that could be the case here, since if the string is being printed, the only code path where this is possible requires `lower` to have been set to something. To silence the warning, set both `lower` and `upper` to 0 explicitly. Signed-off-by: Saikrishna Arcot <[email protected]>
prsunny
approved these changes
Feb 14, 2024
cscarpitta
pushed a commit
to cscarpitta/sonic-swss
that referenced
this pull request
Apr 5, 2024
GCC 12 (in Debian Bookworm) claims that on armhf targets, the `lower` local variable in `Orch::generateIdListFromMap` could potentially be used uninitialized a few lines later when it's being converted to a string. I don't see how that could be the case here, since if the string is being printed, the only code path where this is possible requires `lower` to have been set to something. To silence the warning, set both `lower` and `upper` to 0 explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
GCC 12 (in Debian Bookworm) claims that on armhf targets, the
lowerlocal variable inOrch::generateIdListFromMapcould potentially be used uninitialized a few lines later when it's being converted to a string. I don't see how that could be the case here, since if the string is being printed, the only code path where this is possible requireslowerto have been set to something. It also only complains about this for armhf and i386 (i.e. 32-bit platforms); amd64 and arm64 (64-bit platforms) are fine. (i386 was manually tested by installing the 32-bit crosscompiler and development headers in a slave container and running the g++ command to compile orch.cpp.)Why I did it
To silence the warning, set both
lowerandupperto 0 explicitly.How I verified it
Details if related