[fpmsyncd]: Add support for SRv6 #3123
Open
+3,866
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscarpitta
force-pushed
the
dplane_fpm_sonic
branch
from
962e839
to
13cfd44
Compare
cscarpitta
force-pushed
the
dplane_fpm_sonic
branch
from
13cfd44
to
525d2e2
Compare
cscarpitta
force-pushed
the
dplane_fpm_sonic
branch
from
525d2e2
to
98225dc
Compare
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cscarpitta
force-pushed
the
dplane_fpm_sonic
branch
3 times, most recently
from
faf75e9
to
171fbfb
Compare
|
@cscarpitta can you rebase it to fix the compile issue? sonic-net/sonic-buildimage#18715 is merged. |
|
This change has been cherry-picked into phoenix wing and used in daily run. |
eddieruan-alibaba
approved these changes
Oct 3, 2024
kperumalbfn
reviewed
Oct 3, 2024
fpmsyncd/routesync.cpp
Outdated
| #define NH_ENCAP_SRV6_ROUTE 101 | ||
|
|
||
| #define RTM_NEWSRV6LOCALSID 1000 | ||
| #define RTM_DELSRV6LOCALSID 1001 |
There was a problem hiding this comment.
These constants are defined in fpmlink.h, do we need it here? Pls remove if not needed.
fpmsyncd/routesync.cpp
Outdated
| @@ -81,6 +145,8 @@ RouteSync::RouteSync(RedisPipeline *pipeline) : | |||
| m_vnet_routeTable(pipeline, APP_VNET_RT_TABLE_NAME, true), | |||
| m_vnet_tunnelTable(pipeline, APP_VNET_RT_TUNNEL_TABLE_NAME, true), | |||
| m_warmStartHelper(pipeline, &m_routeTable, APP_ROUTE_TABLE_NAME, "bgp", "bgp"), | |||
| m_srv6LocalSidTable(pipeline, APP_SRV6_MY_SID_TABLE_NAME, true), | |||
There was a problem hiding this comment.
minor: could we change the table name to mysidTable. I think we changed most of the reference of localSid to MySid.
|
|
||
| if (vpn_sid.empty()) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
Error logs for debugging?
cscarpitta
force-pushed
the
dplane_fpm_sonic
branch
2 times, most recently
from
f53196b
to
a1671dc
Compare
* Extend fpmsyncd to process SRv6 routes and local SIDs received from FRR * Add test cases to verify SRv6 functionality Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
force-pushed
the
dplane_fpm_sonic
branch
from
a1671dc
to
b0c2f60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#1620
What I did
Extended fpmsyncd to process Netlink TLVs containing SRv6 information (SRv6 local SIDs and routes).
Why I did it
fpmsyncd did not process Netlink TLVs containing SRv6 information (SRv6 local SIDs and routes).
How I verified it
Added new test cases in
test_srv6.py.