[intfsorch]: Add setRouterIntfsMtu function #574
Conversation
orchagent/portsorch.cpp
Outdated
| @@ -1532,6 +1534,10 @@ void PortsOrch::doPortTask(Consumer &consumer) | |||
| p.m_mtu = mtu; | |||
| m_portList[alias] = p; | |||
| SWSS_LOG_NOTICE("Set port %s MTU to %u", alias.c_str(), mtu); | |||
| if (!p.m_rif_id) | |||
| { | |||
| gIntfsOrch->setRouterIntfsMtu(p, mtu); | |||
There was a problem hiding this comment.
Do you need to pass the value? Isnt it the same as p.m_mtu?
There was a problem hiding this comment.
thanks for catching this. i'll update it.
orchagent/intfsorch.cpp
Outdated
| port.m_alias.c_str(), mtu, status); | ||
| return true; | ||
| } | ||
| SWSS_LOG_NOTICE("Set router interface %s MTU to %u", |
There was a problem hiding this comment.
I think this could be INFO
There was a problem hiding this comment.
i'd like to keep it as NOTICE since it's possible to change port channel MTUs or VLAN mtus and we'd like to know the corresponding MTU changes for the router interfaces.
orchagent/intfsorch.cpp
Outdated
| { | ||
| SWSS_LOG_ERROR("Failed to set router interface %s MTU to %u, rv:%d", | ||
| port.m_alias.c_str(), mtu, status); | ||
| return true; |
orchagent/intfsorch.cpp
Outdated
| } | ||
| SWSS_LOG_NOTICE("Set router interface %s MTU to %u", | ||
| port.m_alias.c_str(), mtu); | ||
| return false; |
orchagent/portsorch.cpp
Outdated
| @@ -1532,6 +1534,10 @@ void PortsOrch::doPortTask(Consumer &consumer) | |||
| p.m_mtu = mtu; | |||
| m_portList[alias] = p; | |||
| SWSS_LOG_NOTICE("Set port %s MTU to %u", alias.c_str(), mtu); | |||
| if (!p.m_rif_id) | |||
|
code looks good. please add vs test. |
|
Change looks good to me, now the ethernet port router intf mtu setting should work as before during system init. Just curious, since in https://github.com/Azure/sonic-swss/pull/545/files you also have lag mtu setting, are you going to address that in orchagent for lag mtu in separate PR? |
|
@jipanyang yes. since the current implementation also doesn't support LAG MTU changes. I'll do it in the separate PRs. |
This function allows the propagation of MTU from port MTU to router interface MTU if the router interface is created based on this port. Once the port MTU gets changes, the router interface MTU will also get changed. Update the VS unit test test_InterfaceChangeMtu case. It will check the data flow from application database to ASIC database. Signed-off-by: Shu0T1an ChenG <[email protected]>
|
|
||
| tbl = swsscommon.ProducerStateTable(pdb, "PORT_TABLE") | ||
| fvs = swsscommon.FieldValuePairs([("mtu", "8888")]) | ||
| tbl.set("Ethernet8", fvs) |
There was a problem hiding this comment.
do we need to configure ethernet8 into rif or it is already in rif.
There was a problem hiding this comment.
in the first test case when the ip is assigned, the associated rif is created
This function allows the propagation of MTU from port MTU to router
interface MTU if the router interface is created based on this port.
Once the port MTU gets changes, the router interface MTU will also
get changed.
Signed-off-by: Shu0T1an ChenG [email protected]