[intfsorch]:add support to change rif mac address

cfgmgr/intfmgr.cpp

@@ -60,6 +60,20 @@ void IntfMgr::setIntfIp(const string &alias, const string &opCmd,
     }
 }
 
+void IntfMgr::setIntfMac(const string &alias, const string &mac_str)
+{
+    stringstream cmd;
+    string res;
+
+    cmd << IP_CMD << " link set " << alias << " address " << mac_str;
+
+    int ret = swss::exec(cmd.str(), res);
+    if (ret)
+    {
+        SWSS_LOG_ERROR("Command '%s' failed with rc %d", cmd.str().c_str(), ret);
+    }
+}
+
 void IntfMgr::setIntfVrf(const string &alias, const string &vrfName)
 {
     stringstream cmd;
@@ -386,6 +400,7 @@ bool IntfMgr::doIntfGeneralTask(const vector<string>& keys,
         alias = alias.substr(0, found);
     }
     bool is_lo = !alias.compare(0, strlen(LOOPBACK_PREFIX), LOOPBACK_PREFIX);
+    string mac = "";
 
     string vrf_name = "";
     string mtu = "";
@@ -399,8 +414,11 @@ bool IntfMgr::doIntfGeneralTask(const vector<string>& keys,
         {
             vrf_name = value;
         }
-
-        if (field == "admin_status")
+        else if (field == "mac_addr")
+        {
+            mac = value;
+        }
+        else if (field == "admin_status")
         {
             adminStatus = value;
         }
@@ -437,6 +455,12 @@ bool IntfMgr::doIntfGeneralTask(const vector<string>& keys,
             setIntfVrf(alias, vrf_name);
         }
 
+        /*Set the mac of interface*/
+        if (!mac.empty())
+        {
+            setIntfMac(alias, mac);
+        }
+
         if (!subIntfAlias.empty())
         {
             if (m_subIntfList.find(subIntfAlias) == m_subIntfList.end())

cfgmgr/intfmgr.h

@@ -25,13 +25,17 @@ class IntfMgr : public Orch
 
     void setIntfIp(const std::string &alias, const std::string &opCmd, const IpPrefix &ipPrefix);
     void setIntfVrf(const std::string &alias, const std::string &vrfName);
+    void setIntfMac(const std::string &alias, const std::string &macAddr);
+
     bool doIntfGeneralTask(const std::vector<std::string>& keys, std::vector<FieldValueTuple> data, const std::string& op);
     bool doIntfAddrTask(const std::vector<std::string>& keys, const std::vector<FieldValueTuple>& data, const std::string& op);
     void doTask(Consumer &consumer);
+
     bool isIntfStateOk(const std::string &alias);
     bool isIntfCreated(const std::string &alias);
     bool isIntfChangeVrf(const std::string &alias, const std::string &vrfName);
     int getIntfIpCount(const std::string &alias);
+
     void addLoopbackIntf(const std::string &alias);
     void delLoopbackIntf(const std::string &alias);
 

orchagent/intfsorch.cpp

@@ -382,6 +382,7 @@ void IntfsOrch::doTask(Consumer &consumer)
     while (it != consumer.m_toSync.end())
     {
         KeyOpFieldsValuesTuple t = it->second;
+        MacAddress mac;
 
         vector<string> keys = tokenize(kfvKey(t), ':');
         string alias(keys[0]);
@@ -419,6 +420,10 @@ void IntfsOrch::doTask(Consumer &consumer)
             {
                 vnet_name = value;
             }
+            else if (field == "mac_addr")
+            {
+                mac = MacAddress(value);
+            }
             else if (field == "mtu")
             {
                 try
@@ -557,6 +562,35 @@ void IntfsOrch::doTask(Consumer &consumer)
                 }
             }
 
+            if (mac)
+            {
+                /* Get mac information and update mac of the interface*/
+                sai_attribute_t attr;
+                attr.id = SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS;
+                memcpy(attr.value.mac, mac.getMac(), sizeof(sai_mac_t));
+
+                /*port.m_rif_id is set in setIntf(), need get port again*/
+                if (gPortsOrch->getPort(alias, port))
+                {
+                    sai_status_t status = sai_router_intfs_api->set_router_interface_attribute(port.m_rif_id, &attr);
+                    if (status != SAI_STATUS_SUCCESS)
+                    {
+                        SWSS_LOG_ERROR("Failed to set router interface mac %s for port %s, rv:%d",
+                                                     mac.to_string().c_str(), port.m_alias.c_str(), status);
+                    }
+                    else
+                    {
+                        SWSS_LOG_NOTICE("Set router interface mac %s for port %s success",
+                                                      mac.to_string().c_str(), port.m_alias.c_str());
+                    }
+                }
+                else
+                {
+                    SWSS_LOG_ERROR("Failed to set router interface mac %s for port %s, getPort fail",
+                                                     mac.to_string().c_str(), alias.c_str());
+                }
+            }
+
             it = consumer.m_toSync.erase(it);
         }
         else if (op == DEL_COMMAND)

tests/test_intf_mac.py

@@ -0,0 +1,244 @@
+from swsscommon import swsscommon
+
+import time
+import json
+
+class TestRouterInterfaceMac(object):
+    def add_ip_address(self, dvs, interface, ip):
+        tbl = swsscommon.Table(dvs.cdb, "INTERFACE")
+        fvs = swsscommon.FieldValuePairs([("NULL", "NULL")])
+        tbl.set(interface, fvs)
+        tbl.set(interface + "|" + ip, fvs)
+        time.sleep(1)
+
+    def remove_ip_address(self, dvs, interface, ip):
+        tbl = swsscommon.Table(dvs.cdb, "INTERFACE")
+        tbl._del(interface + "|" + ip);
+        tbl.hdel(interface, "NULL")
+        time.sleep(1)
+
+    def set_mac(self, dvs, interface, mac):
+        tbl = swsscommon.Table(dvs.cdb, "INTERFACE")
+        fvs = swsscommon.FieldValuePairs([("mac_addr", mac)])
+        tbl.set(interface, fvs)
+        time.sleep(1)
+
+    def remove_mac(self, dvs, interface):
+        tbl = swsscommon.Table(dvs.cdb, "INTERFACE")
+        tbl.hdel(interface, "mac_addr")
+        time.sleep(1)
+
+    def find_mac(self, dvs, interface, mac):
+        port_oid = dvs.asicdb.portnamemap[interface]
+
+        tbl = swsscommon.Table(dvs.adb, "ASIC_STATE:SAI_OBJECT_TYPE_ROUTER_INTERFACE")
+        intf_entries = tbl.getKeys()
+        for key in intf_entries:
+            (status, fvs) = tbl.get(key)
+            assert status == True
+            values = dict(fvs)
+            if "SAI_ROUTER_INTERFACE_TYPE_PORT" != values["SAI_ROUTER_INTERFACE_ATTR_TYPE"]:
+                continue
+            if port_oid == values["SAI_ROUTER_INTERFACE_ATTR_PORT_ID"] and mac == values["SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS"]:
+                return True
+        return False
+
+    def test_InterfaceSetMac(self, dvs, testlog):
+        dvs.setup_db()
+
+        # assign IP to interface
+        self.add_ip_address(dvs, "Ethernet8", "10.0.0.4/31")
+
+        # set MAC to interface
+        self.set_mac(dvs, "Ethernet8", "6C:EC:5A:11:22:33")
+
+        # check application database
+        tbl = swsscommon.Table(dvs.pdb, "INTF_TABLE")
+        (status, fvs) = tbl.get("Ethernet8")
+        assert status == True
+        values = dict(fvs)
+        assert values["mac_addr"] == "6C:EC:5A:11:22:33"
+
+        # check ASIC router interface database
+        src_mac_addr_found = self.find_mac(dvs, "Ethernet8", "6C:EC:5A:11:22:33")
+        assert src_mac_addr_found == True
+
+        # remove IP from interface
+        self.remove_ip_address(dvs, "Ethernet8", "10.0.0.4/31")
+
+        # remove MAC from interface
+        self.remove_mac(dvs, "Ethernet8")
+
+    def test_InterfaceChangeMac(self, dvs, testlog):
+        dvs.setup_db()
+
+        # assign IP to interface
+        self.add_ip_address(dvs, "Ethernet12", "12.0.0.4/31")
+
+        # set MAC to interface
+        self.set_mac(dvs, "Ethernet12", "6C:EC:5A:22:33:44")
+
+        # change interface MAC
+        self.set_mac(dvs, "Ethernet12", "6C:EC:5A:33:44:55")
+
+        # check application database
+        tbl = swsscommon.Table(dvs.pdb, "INTF_TABLE")
+        (status, fvs) = tbl.get("Ethernet12")
+        assert status == True
+        values = dict(fvs)
+        assert values["mac_addr"] == "6C:EC:5A:33:44:55"
+
+        # check ASIC router interface database
+        src_mac_addr_found = self.find_mac(dvs, "Ethernet12", "6C:EC:5A:33:44:55")
+        assert src_mac_addr_found == True
+
+        # remove IP from interface
+        self.remove_ip_address(dvs, "Ethernet12", "12.0.0.4/31")
+
+        # remove MAC from interface
+        self.remove_mac(dvs, "Ethernet12")
+
+class TestLagRouterInterfaceMac(object):
+    def create_port_channel(self, dvs, alias):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL")
+        fvs = swsscommon.FieldValuePairs([("admin_status", "up"),
+                                          ("mtu", "9100")])
+        tbl.set(alias, fvs)
+        time.sleep(1)
+
+    def remove_port_channel(self, dvs, alias):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL")
+        tbl._del(alias)
+        time.sleep(1)
+
+    def add_port_channel_members(self, dvs, lag, members):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL_MEMBER")
+        fvs = swsscommon.FieldValuePairs([("NULL", "NULL")])
+        for member in members:
+            tbl.set(lag + "|" + member, fvs)
+            time.sleep(1)
+
+    def remove_port_channel_members(self, dvs, lag, members):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL_MEMBER")
+        for member in members:
+            tbl._del(lag + "|" + member)
+            time.sleep(1)
+
+    def add_ip_address(self, dvs, interface, ip):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL_INTERFACE")
+        fvs = swsscommon.FieldValuePairs([("NULL", "NULL")])
+        tbl.set(interface, fvs)
+        tbl.set(interface + "|" + ip, fvs)
+        time.sleep(1)
+
+    def remove_ip_address(self, dvs, interface, ip):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL_INTERFACE")
+        tbl._del(interface + "|" + ip);
+        tbl.hdel(interface, "NULL")
+        time.sleep(1)
+
+    def set_mac(self, dvs, interface, mac):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL_INTERFACE")
+        fvs = swsscommon.FieldValuePairs([("mac_addr", mac)])
+        tbl.set(interface, fvs)
+        time.sleep(1)
+
+    def remove_mac(self, dvs, interface):
+        tbl = swsscommon.Table(dvs.cdb, "PORTCHANNEL_INTERFACE")
+        tbl.hdel(interface, "mac_addr")
+        time.sleep(1)
+
+    def find_mac(self, dvs, lag_oid, mac):
+        tbl = swsscommon.Table(dvs.adb, "ASIC_STATE:SAI_OBJECT_TYPE_ROUTER_INTERFACE")
+        intf_entries = tbl.getKeys()
+
+        for key in intf_entries:
+            (status, fvs) = tbl.get(key)
+            assert status == True
+            values = dict(fvs)
+            if "SAI_ROUTER_INTERFACE_TYPE_PORT" != values["SAI_ROUTER_INTERFACE_ATTR_TYPE"]:
+                continue
+            if lag_oid == values["SAI_ROUTER_INTERFACE_ATTR_PORT_ID"] and mac == values["SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS"]:
+                return True
+        return False
+
+    def test_InterfaceSetMac(self, dvs, testlog):
+        dvs.setup_db()
+
+        # create port channel
+        self.create_port_channel(dvs, "PortChannel001")
+
+        # assign IP to interface
+        self.add_ip_address(dvs, "PortChannel001", "30.0.0.4/31")
+
+        # set MAC to interface
+        self.set_mac(dvs, "PortChannel001", "6C:EC:5A:11:22:33")
+
+        # check application database
+        tbl = swsscommon.Table(dvs.pdb, "INTF_TABLE")
+        (status, fvs) = tbl.get("PortChannel001")
+        assert status == True
+        values = dict(fvs)
+        assert values["mac_addr"] == "6C:EC:5A:11:22:33"
+
+        # get PortChannel oid; When sonic-swss pr885 is complete, you can get oid directly from COUNTERS_LAG_NAME_MAP, which would be better.
+        lag_tbl = swsscommon.Table(dvs.adb, "ASIC_STATE:SAI_OBJECT_TYPE_LAG")
+        lag_entries = lag_tbl.getKeys()
+        # At this point there should be only one lag in the system, which is PortChannel001.
+        assert len(lag_entries) == 1
+        lag_oid = lag_entries[0]
+
+        # check ASIC router interface database
+        src_mac_addr_found = self.find_mac(dvs, lag_oid, "6C:EC:5A:11:22:33")
+        assert src_mac_addr_found == True
+
+        # remove IP from interface
+        self.remove_ip_address(dvs, "PortChannel001", "30.0.0.4/31")
+
+        # remove MAC from interface
+        self.remove_mac(dvs, "PortChannel001")
+
+        # remove port channel
+        self.remove_port_channel(dvs, "PortChannel001")
+
+    def test_InterfaceChangeMac(self, dvs, testlog):
+        dvs.setup_db()
+
+        # create port channel
+        self.create_port_channel(dvs, "PortChannel002")
+
+        # assign IP to interface
+        self.add_ip_address(dvs, "PortChannel002", "32.0.0.4/31")
+
+        # set MAC to interface
+        self.set_mac(dvs, "PortChannel002", "6C:EC:5A:22:33:44")
+
+        # change interface MAC
+        self.set_mac(dvs, "PortChannel002", "6C:EC:5A:33:44:55")
+
+        # check application database
+        tbl = swsscommon.Table(dvs.pdb, "INTF_TABLE")
+        (status, fvs) = tbl.get("PortChannel002")
+        assert status == True
+        values = dict(fvs)
+        assert values["mac_addr"] == "6C:EC:5A:33:44:55"
+
+        # get PortChannel oid; When sonic-swss pr885 is complete, you can get oid directly from COUNTERS_LAG_NAME_MAP, which would be better.
+        lag_tbl = swsscommon.Table(dvs.adb, "ASIC_STATE:SAI_OBJECT_TYPE_LAG")
+        lag_entries = lag_tbl.getKeys()
+        # At this point there should be only one lag in the system, which is PortChannel002.
+        assert len(lag_entries) == 1
+        lag_oid = lag_entries[0]
+
+        # check ASIC router interface database
+        src_mac_addr_found = self.find_mac(dvs, lag_oid, "6C:EC:5A:33:44:55")
+        assert src_mac_addr_found == True
+
+        # remove IP from interface
+        self.remove_ip_address(dvs, "PortChannel002", "32.0.0.4/31")
+
+        # remove MAC from interface
+        self.remove_mac(dvs, "PortChannel002")
+
+        # remove port channel
+        self.remove_port_channel(dvs, "PortChannel002")