Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub port interface implementation #969

Merged
merged 57 commits into from
Nov 8, 2019
Merged

Sub port interface implementation #969

merged 57 commits into from
Nov 8, 2019

Commits on Jun 28, 2019

  1. Remove unused data member 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    ccbfb48 View commit details
    Browse the repository at this point in the history

  2. IntfMgr parses dot1q interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    6c99720 View commit details
    Browse the repository at this point in the history

  3. Set dot1q interface state 

    Add function declaration

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    9a1dde4 View commit details
    Browse the repository at this point in the history

  4. Fix compile error 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    ed9f2e9 View commit details
    Browse the repository at this point in the history

  5. Remove sub interface from STATE_DB in DEL_COMMAND 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    4ddb2da View commit details
    Browse the repository at this point in the history

  6. Create sub interface only once; retry if netlink command fails 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    fb8a564 View commit details
    Browse the repository at this point in the history

  7. Follow naming convention 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    fb045d3 View commit details
    Browse the repository at this point in the history

  8. Create Port object for sub interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    b15eee6 View commit details
    Browse the repository at this point in the history

  9. Introduce parent_port_id in Port to track the oid of the parent inter… 

    …face

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    a02dc31 View commit details
    Browse the repository at this point in the history

  10. Deal with sub port case in creating router interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    f8e482a View commit details
    Browse the repository at this point in the history

  11. Let parent port track its child sub ports 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    f5f49d3 View commit details
    Browse the repository at this point in the history

  12. Remove admin status field and its processing in CONFIG_DB; Runtime mt… 

    …u change to sub interface

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    5cf5074 View commit details
    Browse the repository at this point in the history

  13. Fix compile error 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    60b3296 View commit details
    Browse the repository at this point in the history

  14. Fix compile error for runtime mtu change 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    3a6ecce View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2019

  1. Move sub port add/remove as member functions to PortsOrch; Add sub in… 

    …terface

rif to flex counter at creation

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    fcd0772 View commit details
    Browse the repository at this point in the history

  2. Fix compile error 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    99c887b View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Remove sub interface alias from IntfMgr::m_subIntfList 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    0014f40 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. Merge remote-tracking branch 'public/master' into sub_intf_master

    @wendani
    wendani committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    789b198 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. Disable mtu config; Inherit mtu from parent port or port channel 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    de1577f View commit details
    Browse the repository at this point in the history

  2. Per sub port interface mtu config 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    fd66f3d View commit details
    Browse the repository at this point in the history

  3. CONFIG_DB table name schema change 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    4f64469 View commit details
    Browse the repository at this point in the history

  4. Explicitly set admin status in creating sub port interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    b57e78c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Set admin status up to host sub port interface if admin_status is not… 

    … specified

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    642c708 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. Remove debugging logs 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    fc54c58 View commit details
    Browse the repository at this point in the history

  2. Define macro for vlan sub interface separator "." 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    b1aff64 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Merge remote-tracking branch 'public/master' into sub_intf_master

    @wendani
    wendani committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    07a85aa View commit details
    Browse the repository at this point in the history

  2. Remove the need to create an object id for vlan in creating a sub port 

    router interface

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    227848c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Add test on creating a sub port interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    a43889a View commit details
    Browse the repository at this point in the history

  2. Consolidate check with one utility 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    892380e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2019

  1. Add test on sub port interface creation 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    1052443 View commit details
    Browse the repository at this point in the history

  2. Add test on adding ip addresses to a sub port interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    d6163db View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. Add test on sub port interface admin status change 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    0b8bd14 View commit details
    Browse the repository at this point in the history

  2. Add test on removing IP addresses from a sub port interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    b09fb5a View commit details
    Browse the repository at this point in the history

  3. Break long statement into multi-lines 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    672ef03 View commit details
    Browse the repository at this point in the history

  4. Add test on removing a sub port interface 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    1207094 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'public/master' into sub_intf_master

    @wendani
    wendani committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    3896135 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Merge remote-tracking branch 'public/master' into sub_intf_master

    @wendani
    wendani committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    6f2d143 View commit details
    Browse the repository at this point in the history

  2. Address comment: validate caller input before concatenate a system call 

    cli

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    e127cf6 View commit details
    Browse the repository at this point in the history

  3. Address comment: include & specify namespace 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    3914387 View commit details
    Browse the repository at this point in the history

  4. Address comment: not use reference 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    5620d26 View commit details
    Browse the repository at this point in the history

  5. Correct BUFFER_PG table schema name in comment 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    4f64be8 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Address comment: not using namespace in header files 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    2a1dab3 View commit details
    Browse the repository at this point in the history

  2. Address comment: remove redundant check 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    018cf2d View commit details
    Browse the repository at this point in the history

  3. Address comment: check parent port name contains only alphanumeric 

    characters

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    67b93d2 View commit details
    Browse the repository at this point in the history

  4. Address comment: remove mtu field processing 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    b33df4e View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2019

  1. check parent port name contains only alphanumeric characters and vlan id 

    contains only numeric characters

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    965dafd View commit details
    Browse the repository at this point in the history

  2. Fix compile error caused by removing namespace swss 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    0ceb374 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. Merge remote-tracking branch 'public/master' into sub_intf_master

    @wendani
    wendani committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    631f3f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Allow buffer profile application after init (i.e., at run time) 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    59049bb View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Fix compile error 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    fd7089e View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Merge remote-tracking branch 'public/master' into sub_intf_master

    @wendani
    wendani committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    759bf2f View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2019

  1. Resolve vs sub port interface test failure 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    0011b12 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Address comments: Handling all default values for fields at the IntfMgr 

    level

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    7f59f07 View commit details
    Browse the repository at this point in the history

  2. Fix compile error; IntfMgr change variable mtu to type string 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    c4bd373 View commit details
    Browse the repository at this point in the history

  3. setIntf: differentiate between create/set sub interface and add/remove 

    sub interface ip addresses

Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    a2a8531 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'public/master' into sub_intf_master

    @wendani
    wendani committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    fe91b6c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Add sub interface to STATE_DB INTERFACE_TABLE introduced by vrf feature 

    Signed-off-by: Wenda Ni <[email protected]>
    @wendani
    wendani committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    bdb92b6 View commit details
    Browse the repository at this point in the history