Add synchronous switch to orch agent #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Jul 21, 2019
|
can't figure out why build on VS is failing, but pretty sure it;s not this change |
stcheng
approved these changes
Jul 22, 2019
jleveque
approved these changes
Jul 22, 2019
|
Retest this please |
3 similar comments
|
Retest this please |
|
Retest this please |
|
Retest this please |
tonytitus
pushed a commit
to tonytitus/sonic-swss
that referenced
this pull request
Jul 31, 2019
antony-rheneus
pushed a commit
to antony-rheneus/sonic-swss
that referenced
this pull request
Aug 1, 2019
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
The sairedis changes related to the SAI here: opencomputeproject/SAI#1365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implement synchronous flag for orchestration agent
Why I did it
To allow dynamic enable synchronous mode from command line
How I verified it
Running from command line and checking if attribute was passed to sairedis lib and waiting for response from syncd.
Details if related
Related to sonic-net/sonic-sairedis#476