Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vstest]: report error when team kernel module is not available #994

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Jul 25, 2019

make explicit failure if team kernel module is not available on the system

Signed-off-by: Guohan Lu [email protected]

What I did

Why I did it

How I verified it

Details if related

make explicit failure if team kernel module is not available on the system

Signed-off-by: Guohan Lu <[email protected]>
@lguohan lguohan requested a review from stcheng July 25, 2019 05:26
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why explicitly check the 'team' module? what scenario did you encounter that is caused by this issue?

@lguohan
Copy link
Contributor Author

lguohan commented Jul 25, 2019

sometimes, the kernel driver package is splitted in base module and extra module packages, and team driver is in the extra package, and extra packet is not automatically installed. then, all lag related vs test will not pass. It is hard to debug that, therefore I am adding explicit check for this requirement.

@lguohan
Copy link
Contributor Author

lguohan commented Jul 25, 2019

this happened on the worker-2, after I manually installed extra kernel module, everything works.

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering do we want to have a controlled or defined environment setup for the server

@lguohan
Copy link
Contributor Author

lguohan commented Jul 25, 2019

yes, we want to have that control, but sometime, the server automatically upgrading their kernel controlled by azure. we need to disable it, but it is a separate issue.

@lguohan lguohan merged commit 6236b8f into sonic-net:master Jul 25, 2019
tonytitus pushed a commit to tonytitus/sonic-swss that referenced this pull request Jul 31, 2019
…c-net#994)

make explicit failure if team kernel module is not available on the system

Signed-off-by: Guohan Lu <[email protected]>
antony-rheneus pushed a commit to antony-rheneus/sonic-swss that referenced this pull request Aug 1, 2019
…c-net#994)

make explicit failure if team kernel module is not available on the system

Signed-off-by: Guohan Lu <[email protected]>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
Instead of having multiple implementation of preparing a SWI image for
secureboot, fast-reboot now reuses boot0.
SWI images booting in regular mode will keep using the old behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants