default value for component constraint

Signed-off-by: Stepan Blyschak <[email protected]>
sonic-net · Mar 25, 2021 · faeadcf · faeadcf
1 parent 3dc793f
commit faeadcf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/sonic_package_manager/manifest.py b/sonic_package_manager/manifest.py
@@ -150,7 +150,7 @@ def unmarshal(self, value):
             ManifestField('version', ParsedMarshaller(Version)),
             ManifestField('name', DefaultMarshaller(str)),
             ManifestField('description', DefaultMarshaller(str), ''),
-            ManifestField('base-os', ParsedMarshaller(ComponentConstraints), dict()),
+            ManifestField('base-os', ParsedMarshaller(ComponentConstraints), ComponentConstraints()),
             ManifestArray('depends', ParsedMarshaller(PackageConstraint)),
             ManifestArray('breaks', ParsedMarshaller(PackageConstraint)),
             ManifestField('init-cfg', DefaultMarshaller(dict), dict()),

diff --git a/tests/sonic_package_manager/test_manifest.py b/tests/sonic_package_manager/test_manifest.py
@@ -2,6 +2,7 @@
 
 import pytest
 
+from sonic_package_manager.constraint import ComponentConstraints
 from sonic_package_manager.manifest import Manifest, ManifestError
 from sonic_package_manager.version import VersionRange
 
@@ -12,7 +13,7 @@ def test_manifest_v1_defaults():
                                  'service': {'name': 'test'}})
     assert manifest['package']['depends'] == []
     assert manifest['package']['breaks'] == []
-    assert manifest['package']['base-os'] == dict()
+    assert manifest['package']['base-os'] == ComponentConstraints()
     assert not manifest['service']['asic-service']
     assert manifest['service']['host-service']