Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"sonic_installer install " command not working in sonic mainline #997

Closed
BaluAlluru opened this issue Jul 17, 2020 · 2 comments · Fixed by #995 or sonic-net/sonic-buildimage#5004
Closed

"sonic_installer install " command not working in sonic mainline #997

BaluAlluru opened this issue Jul 17, 2020 · 2 comments · Fixed by #995 or sonic-net/sonic-buildimage#5004
Assignees
@jleveque
Labels
Bug

Comments

@BaluAlluru
Copy link

Steps to reproduce the issue:

  1. load sonic Jenkins image 350 on the box.
  2. execute the command "sonic_installer install "
  3. Observe Error "NameError: name 'cli' is not defined"

Describe the results you received:
root@sonic:/home/admin# sonic_installer install /home/admin/sonic-broadcom.bin
Traceback (most recent call last):
File "/usr/bin/sonic-installer", line 8, in
from sonic_installer.main import sonic_installer
File "/usr/lib/python2.7/dist-packages/sonic_installer/main.py", line 610, in
@cli.command('verify-next-image')
NameError: name 'cli' is not defined

Describe the results you expected:
root@sonic:/home/admin# sudo sonic_installer install /home/admin/sonic-broadcom.bin
New image will be installed, continue? [y/N]: y
Installing image SONiC-OS-master.0-adad5499 and setting it as default...
Command: bash /home/admin/sonic-broadcom.bin
Verifying image checksum ... OK.
Preparing image archive ... OK.
Installing SONiC in SONiC
....

Additional information you deem important (e.g. issue happens only occasionally):

root@sonic:/home/admin# show version

SONiC Software Version: SONiC.master.350-1ca47da4
Distribution: Debian 10.4
Kernel: 4.19.0-9-2-amd64
Build commit: 1ca47da
Build date: Thu Jul 16 20:16:33 UTC 2020
Built by: johnar@jenkins-worker-11

**Attach debug file `sudo generate_dump`:**

sonic_dump_sonic_20200717_223808.tar.gz
@BaluAlluru BaluAlluru changed the title "sonic-installer install " command not working in sonic mainline "sonic_installer install " command not working in sonic mainline Jul 17, 2020
@rlhui
Copy link
Contributor

rlhui commented Jul 17, 2020

@jleveque - Hi Joe, could this be related to a recent change #983? Thanks.

@jleveque
Copy link
Contributor

jleveque commented Jul 17, 2020 •
edited
Loading

@rlhui: Yes. The root group name was changed from cli to sonic_installer in #983. However, verify-next-image subcommand was being added in an already-open PR #979 at the time. It did not get updated before merge. I have opened a PR to align this command here: #995

@lguohan lguohan transferred this issue from sonic-net/sonic-buildimage Jul 17, 2020
@lguohan lguohan linked a pull request Jul 17, 2020 that will close this issue
[sonic-installer] Update group name for 'verify-next-image' subcommand #995
Merged
@jleveque jleveque self-assigned this Jul 17, 2020
@jleveque jleveque added the Bug label Jul 17, 2020
@jleveque jleveque mentioned this issue Jul 20, 2020
Merged
jleveque added a commit to sonic-net/sonic-buildimage that referenced this issue Jul 20, 2020
@jleveque
[sonic-utilities] Update submodule (#5004)
6ef199f 
* src/sonic-utilities a23479e...82dfe50 (3):
  > [sonic-installer] Update group name for 'verify-next-image' subcommand (#/995)
  > [acl_loader] Fix bugs in acl_loader (#991)
  > [show] Add support for QSFP-DD cables on 'show' command (#989)

This submodule update resolves sonic-net/sonic-utilities#997 by including PR sonic-net/sonic-utilities#995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleveque jleveque

Labels
Bug
Projects
None yet
Milestone
No milestone
3 participants
@jleveque @rlhui @BaluAlluru