[counterpoll] Add new FC group for port buffer drop counters. #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Faryma <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
retest this please |
1 similar comment
|
retest this please |
|
need unit test for the newly added feature. |
lguohan
requested changes
Aug 12, 2020
Signed-off-by: Mykola Faryma <[email protected]>
daall
approved these changes
Aug 25, 2020
added 2 commits
August 27, 2020 14:40
* Fix review comments Signed-off-by: Volodymyr Samotiy <[email protected]>
…o b201911 Signed-off-by: Volodymyr Samotiy <[email protected]> Conflicts: sonic-utilities-tests/mock_tables/config_db.json
|
This pull request introduces 5 alerts when merging a9563de into b0ac781 - view on LGTM.com new alerts:
|
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Fix error when running 'show lldp table' or 'show lldp neighbor' through SSH command. (sonic-net#1067) [201911]: Multi asic show interface support (sonic-net#1070) [counterpoll] Add new FC group for port buffer drop counters (sonic-net#1024) [201911] show interface portchannel support for Multi ASIC (sonic-net#1071) Fix a typo in mellanox_buffer_migrator (sonic-net#1090) Fix pfcwd stats crash with invalid queue name (sonic-net#1077) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018) enable watchdog before running platform specific reboot plugin (sonic-net#1037) Add namespace of the process in the coredump filename. (sonic-net#1091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma [email protected]
Add new FC group for port buffer drop counters.
See sonic-net/sonic-buildimage#5093
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)