First code-drop dealing with intf_description and intf_status enhancements #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments I have taken care of the following items as part of this patch. There is another patch coming right after with changes made over a different repo: * Implemented a proper "show interface description" command -- i entirely removed the old one. * Enabled user to query system for a specific interface. * Extended "show interface status" command to do the same as above (query a specific interface). * Rewrote "show interface status" and integrated this code with "show interface description" one to prevent code-duplication and enhance modularity. * Added "speed" attribute as part of "show interface status" command. admin@lnos-x1-a-asw02:~$ show interfaces description Command: intfutil description Interface Oper Admin Alias Description ----------- ------ ------- ------------- ----------------------- Ethernet112 up up fiftyGigE1/9 Special interface no. 1 Ethernet114 down down fiftyGigE1/10 N/A Ethernet116 up up fiftyGigE1/11 Special interface no. 2 Ethernet118 down down fiftyGigE1/12 N/A Ethernet120 up up fiftyGigE1/13 N/A Ethernet122 down down fiftyGigE1/14 N/A Ethernet124 down up fiftyGigE1/15 N/A admin@lnos-x1-a-asw02:~$ show interfaces status | more Command: intfutil status Interface Lanes Speed MTU Alias Oper Admin ----------- ------- ------- ----- ------------- ------ ------- Ethernet112 113,114 50G 9100 fiftyGigE1/9 up up Ethernet114 115,116 N/A 1500 fiftyGigE1/10 down down Ethernet116 117,118 50G 9100 fiftyGigE1/11 up up Ethernet118 119,120 N/A 1500 fiftyGigE1/12 down down Ethernet120 121,122 N/A 9100 fiftyGigE1/13 up up Ethernet122 123,124 N/A 1500 fiftyGigE1/14 down down Ethernet124 125,126 N/A 9100 fiftyGigE1/15 down up
|
rodnymolina
pushed a commit
to rodnymolina/sonic-buildimage
that referenced
this pull request
Dec 4, 2017
…ements. Here i'm adding minor extensions to support "show interface description" command. Please refer to PR#158 for more details: sonic-net/sonic-utilities#158
jleveque
suggested changes
Dec 4, 2017
scripts/intfutil
Outdated
|
|
||
|
|
||
| def main(args): | ||
| #command, intf_name): |
jleveque
approved these changes
Dec 5, 2017
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 7, 2017
…rface-status enhancements (#1207) * Final code-drop for interface-description and interface-status enhancements. Here i'm adding minor extensions to support "show interface description" command. Please refer to PR#158 for more details: sonic-net/sonic-utilities#158 * Add interface-description UT and adjust logic to have 'description' field being optional RB= G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A= * Updating reference to sonic-utilities to collect latest changes
Merged
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
…on 3 (sonic-net#158) xcvrd would crash on platforms which support media settings with Python 3 because division would result in a float rather than an int. Fix using floor division.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[Namespace]: Fix SAI_ID key used in cpfcIfTable and csqIfQosGroupStatsTable implementation (sonic-net#138) Implementation changes for CiscoBgp4MIB (sonic-net#158) [ciscoSwitchQosMIB]: Remove invocation of update_data function during (sonic-net#161) Signed-off-by: Abhishek Dosi <[email protected]>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…g Loopback, PRBS modes on the Y cable (sonic-net#158) * [sonic_y_cable] Add support for measuring BER and EYE scan with Loopback, PRBS and Mission modes. What is the motivation for this PR? To add the necessary support for measuring BER and EYE scan, and run PRBS/Loopback modes on the Y cable How did you do it? Added the changes in sonic-platform-common module in the y_cable.py file How did you verify/test it? opened a python shell and ran the API's manually and test verified the values are correct. Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken care of the following items as part of this patch. There is another patch coming right after with changes made over a different repo:
admin@lnos-x1-a-asw02:~$ show interfaces description
Command: intfutil description
Interface Oper Admin Alias Description
Ethernet112 up up fiftyGigE1/9 Special interface no. 1
Ethernet114 down down fiftyGigE1/10 N/A
Ethernet116 up up fiftyGigE1/11 Special interface no. 2
Ethernet118 down down fiftyGigE1/12 N/A
Ethernet120 up up fiftyGigE1/13 N/A
Ethernet122 down down fiftyGigE1/14 N/A
Ethernet124 down up fiftyGigE1/15 N/A
admin@lnos-x1-a-asw02:~$ show interfaces status | more
Command: intfutil status
Interface Lanes Speed MTU Alias Oper Admin
Ethernet112 113,114 50G 9100 fiftyGigE1/9 up up
Ethernet114 115,116 N/A 1500 fiftyGigE1/10 down down
Ethernet116 117,118 50G 9100 fiftyGigE1/11 up up
Ethernet118 119,120 N/A 1500 fiftyGigE1/12 down down
Ethernet120 121,122 N/A 9100 fiftyGigE1/13 up up
Ethernet122 123,124 N/A 1500 fiftyGigE1/14 down down
Ethernet124 125,126 N/A 9100 fiftyGigE1/15 down up