Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[route_check] Filter out VNET routes #1612

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

volodymyrsamotiy
Copy link
Collaborator

Signed-off-by: Volodymyr Samotiy [email protected]

What I did

Fixed errors related to VNET routes printed by route_check script.

How I did it

Filtered out VNET routes for the list of routes that are taken into account by route_check script.

How to verify it

  1. Configure VNET routes and run route_check script on the switch
  2. Verify that no errors are onserved

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Volodymyr Samotiy <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented May 13, 2021

This pull request introduces 1 alert when merging 1cad50b into ad801bf - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@prsunny
Copy link
Contributor

prsunny commented May 13, 2021

please add a unit-test

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Contributor

prsunny commented Jun 11, 2021

@volodymyrsamotiy , could you please add a unit-test?

liat-grozovik
liat-grozovik previously approved these changes Jul 7, 2021
@liat-grozovik
Copy link
Collaborator

@prsunny on which branches this is required?

@liat-grozovik
Copy link
Collaborator

@prsunny on which branches this is required?

@prsunny can you please refer to the question?

@prsunny
Copy link
Contributor

prsunny commented Jul 20, 2021

@prsunny on which branches this is required?

@prsunny can you please refer to the question?

  1. We already have this in 201911. Btw, I already marked the labels based on your question.

* Add unit test

Signed-off-by: Volodymyr Samotiy <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2021

This pull request introduces 1 alert when merging 6ebb5c4 into a99d56d - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@prsunny prsunny merged commit 04cc047 into sonic-net:master Aug 20, 2021
qiluo-msft pushed a commit that referenced this pull request Aug 23, 2021
* Filter out VNET routes, Fix errors related to VNET routes printed by route_check script
Signed-off-by: Volodymyr Samotiy <[email protected]>
judyjoseph pushed a commit that referenced this pull request Aug 26, 2021
* Filter out VNET routes, Fix errors related to VNET routes printed by route_check script
Signed-off-by: Volodymyr Samotiy <[email protected]>
vaibhavhd added a commit to sonic-net/sonic-buildimage that referenced this pull request Aug 26, 2021
Update sonic-utilities submodule to latest in 202012 branch:

[show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled sonic-net/sonic-utilities#1678
[route_check] Filter out VNET routes sonic-net/sonic-utilities#1612
[Show] Update the subcommands of Kdump. sonic-net/sonic-utilities#1682
Add mock support for swsscommon classes sonic-net/sonic-utilities#1780
[acl_loader]: add iptype match to the rules for dataplane acl sonic-net/sonic-utilities@205aff8
[202012][fast-reboot] Remove FLEX_COUNTER_TABLE from config_db.json before fast-reboot sonic-net/sonic-utilities#1774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants