SFP-Refactor: Vendor revision is not displayed properly #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindmani-1
changed the title
|
@keboliu can you please review |
prgeor
approved these changes
Dec 1, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@aravindmani-1 can you also attach the output of "sfputil show eeprom" for QSFP28/QSFP+ ? |
5 tasks
Closed
5 tasks
4 tasks
This was referenced Jan 19, 2022
wangxin
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jan 20, 2022
What is the motivation for this PR? In test_transceiver_info the key of hardware_rev has been changed to vendor_rev. According to these PRs(sonic-net/sonic-platform-daemons#231, sonic-net/sonic-utilities#1950), now only master branch support the key of vendor_rev. So, for other branches it still keeps the key of hardware_rev. How did you do it? For latest master release, use "vendor_rev" as transceiver info key. For release in ["201911", "202012", "202106", "202111"], use "hardware_rev" as transceiver info key. How did you verify/test it? Run test_transceiver_info on different branches, for example: master, 202012.
This was referenced Feb 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modified vendor revision that displayed hardware revision
How I did it
Modified SFP plugins to display correct fields
How to verify it
Check sfpshow/sfputil eeprom output
Previous command output (if the output of a command-line utility has changed)
root@SONIC:~# sfputil show eeprom -p Ethernet160
Ethernet160: SFP EEPROM detected
Application Advertisement: N/A
Connector: No separable connector
Encoding: N/A
Extended Identifier: Power Class 6 (12.0W Max)
Extended RateSelect Compliance: N/A
Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
Length Cable Assembly(m): 10.0
Nominal Bit Rate(100Mbs): 0
Specification compliance: active_cable_media_interface
Vendor Date Code(YYYY-MM-DD Lot): 2020-01-07
Vendor Name: DELL EMC
Vendor OUI: ac-4a-fe
Vendor PN: 9GMDY
Vendor Rev: 1.1
Vendor SN: CN04HQ000130034
New command output (if the output of a command-line utility has changed)
root@SONIC:~# sfputil show eeprom -p Ethernet160
Ethernet160: SFP EEPROM detected
Application Advertisement: N/A
Connector: No separable connector
Encoding: N/A
Extended Identifier: Power Class 6 (12.0W Max)
Extended RateSelect Compliance: N/A
Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
Length Cable Assembly(m): 10.0
Nominal Bit Rate(100Mbs): 0
Specification compliance: active_cable_media_interface
Vendor Date Code(YYYY-MM-DD Lot): 2020-01-07
Vendor Name: DELL EMC
Vendor OUI: ac-4a-fe
Vendor PN: 9GMDY
Vendor Rev: A0
Vendor SN: CN04HQ000130034