Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vrf UT failed issue #2309

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Aug 12, 2022

What I did

Fix VRF bind/unbind UT failed issue.

How I did it

Mock DBInterface.close() method.

How to verify it

Add new UT.
Pass all UT.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@liuh-80 liuh-80 marked this pull request as ready for review August 12, 2022 08:59
print(result.exit_code, result.output)
assert result.exit_code == 0

def test_intf_vrf_bind_unbind(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this duplicate testcase.

Copy link
Contributor Author

@liuh-80 liuh-80 Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, dupe by copy paste

preetham-singh
preetham-singh previously approved these changes Aug 12, 2022
@liuh-80 liuh-80 merged commit 9282e6c into sonic-net:master Aug 15, 2022
@liuh-80 liuh-80 deleted the dev/liuh/fix-ut-issue branch August 15, 2022 03:05
yxieca pushed a commit that referenced this pull request Sep 1, 2022
#### What I did
    Fix VRF bind/unbind UT failed issue.

#### How I did it
    Mock DBInterface.close() method.

#### How to verify it
    Add new UT.
    Pass all UT.

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Sep 7, 2022
Update sonic-utilities submodule pointer to include the following:
* [route_check]: Ignore standalone tunnel routes (sonic-net#2325) ([sonic-net#2346](sonic-net/sonic-utilities#2346))
* [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([sonic-net#2333](sonic-net/sonic-utilities#2333))
* Subinterface vrf bind issue fix ([sonic-net#2211](sonic-net/sonic-utilities#2211))
* [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([sonic-net#2270](sonic-net/sonic-utilities#2270))
* Fix vrf UT failed issue ([sonic-net#2309](sonic-net/sonic-utilities#2309))

Signed-off-by: dprital <[email protected]>
yxieca pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Sep 8, 2022
Update sonic-utilities submodule pointer to include the following:
* [route_check]: Ignore standalone tunnel routes (#2325) ([#2346](sonic-net/sonic-utilities#2346))
* [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([#2333](sonic-net/sonic-utilities#2333))
* Subinterface vrf bind issue fix ([#2211](sonic-net/sonic-utilities#2211))
* [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([#2270](sonic-net/sonic-utilities#2270))
* Fix vrf UT failed issue ([#2309](sonic-net/sonic-utilities#2309))

Signed-off-by: dprital <[email protected]>

Signed-off-by: dprital <[email protected]>
preetham-singh pushed a commit to preetham-singh/sonic-utilities that referenced this pull request Nov 21, 2022
#### What I did
    Fix VRF bind/unbind UT failed issue.

#### How I did it
    Mock DBInterface.close() method.

#### How to verify it
    Add new UT.
    Pass all UT.

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants