-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[show] add support for gRPC show commands for active-active
#2629
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cbea455
[show] add support for gRPC show commands for `active-active`
vdahiya12 cd8d59d
add commits
vdahiya12 b52e47a
Merge branch 'cli-en-1' of https://github.com/vdahiya12/sonic-utilities
vdahiya12 9497392
fix
vdahiya12 60a03dc
fix tests
vdahiya12 f832df7
add a test
vdahiya12 6d4a784
add coverage
vdahiya12 66ee18c
add all
vdahiya12 a25ea90
fix tests
vdahiya12 b61c279
fix n
vdahiya12 1f43a7b
add some enhancements
vdahiya12 adb1f4b
add all
vdahiya12 49e4156
add more tests
vdahiya12 6553604
add
vdahiya12 3a36590
fix
vdahiya12 3b59511
add fix tests
vdahiya12 550f169
add UT
vdahiya12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the
presence
column is thestatus
field inTRANSCEIVER_STATUS
? What does this represent in active-active case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So presence is from xcvrd platform API side telling if the cable is present or not, if the cable is plugged in shows True and False otherwise, its recorded in
TRANSCEIVER_STATUS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its same for
active-active
oractive standby