Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202012][db_migrator] Remove hardcoded config and migrate config from minigraph #2924

Merged
merged 2 commits into from
Jul 26, 2023
Merged

[202012][db_migrator] Remove hardcoded config and migrate config from minigraph #2924

merged 2 commits into from
Jul 26, 2023

Commits on Jul 21, 2023

  1. [db_migrator] Remove hardcoded config and migrate config from minigra… 

    …ph (sonic-net#2887)

Microsoft ADO: 18217044

This PR is follow up to an old PR: sonic-net#2515

This PR addresses two issues:

Not migrating RESTAPI, TELEMETRY, DEVICE_METADATA entries if they are not supported in target image's minigraph.py.
Not migrating these entries if minigraph.xml file is missing.
Not maintaining the config for these tables in two different places. Currently db migrator has its own constants, and minigraph.py maintains its own.
How I did it
This change removes hardcoding config in migrator code, and migrating the config for RESTAPI, TELEMETRY, DEVICE_METADATA from minigraph generator.

How to verify it
Tested on a physical device.
    @vaibhavhd
    vaibhavhd committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a660a8f View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Merge branch '202012' into migrator-cherrypick

    @qiluo-msft
    qiluo-msft authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3a7d039 View commit details
    Browse the repository at this point in the history