[build] Fix dependency issue between responses and urllib3 package. #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
approved these changes
Jul 27, 2023
liushilongbuaa
added a commit
to liushilongbuaa/sonic-utilities
that referenced
this pull request
Jul 27, 2023
…onic-net#2928) * [build] Fix dependency issue between responses and urllib3 package.
liushilongbuaa
added a commit
to liushilongbuaa/sonic-utilities
that referenced
this pull request
Jul 27, 2023
…onic-net#2928) * [build] Fix dependency issue between responses and urllib3 package.
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…onic-net#2928) * [build] Fix dependency issue between responses and urllib3 package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Update urllib3 to V2.
How I did it
Some package depends on urllib3V2.
But urllib3 is pinned on V1 for docker 4.4.1 not support urllibV2.
Now docker is upgraded to V6. The issue didn't exist.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)