-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route_check: Skip route checks if bgp feature is not enabled #3075
route_check: Skip route checks if bgp feature is not enabled #3075
Conversation
If bgp is not enabled, get_frr_routes() gets empty list and route check fails and throws a traceback. Adding check to check for frr routes only when bgp feature is enabled. On the Chassis supervisor, bgp may be disabled. Signed-off-by: Anand Mehra [email protected]
Signed-off-by: Anand Mehra <[email protected]>
only an issue from 202305 up |
@anamehra can you resolve the conflicts? The files have been modified for multi-asic support... |
KeyError: 'namespace-list' Stack trace
tests/route_check_test.py:240: self = <tests.route_check_test.TestRouteCheck object at 0x7f04c0d0bf10>
E KeyError: 'namespace-list' tests/route_check_test.py:244: KeyError |
Hi @deepak-singhal0408 , I am checking on the errors after the conflict merge. |
Signed-off-by: anamehra <[email protected]>
@deepak-singhal0408 , please review. Thanks! |
@anamehra : can we skip complete script execution if Reason for this request in future someone can add more checks based on FRR so possible we will hit similar issue again. Skipping at top level will help in such cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per above comment.
Signed-off-by: anamehra <[email protected]>
@anamehra please create PR for 202305. |
@anamehra cherry pick conflict, pls resubmit separate PR to 202305. |
@anamehra @deepak-singhal0408 #3075 and #3077 have blocked sonic-utilities repo sub-module advance in sonic-buildimage repo. |
Hi @anamehra , could you resubmit this PR? It was reverted earlier.. Thanks! |
@anamehra , is this resubmitted? |
Hi @anamehra , we are waiting on this PR.. if you are busy, please let me know, we can create this PR.. Thanks.. |
If bgp is not enabled, get_frr_routes() gets empty list and route check fails and throws a traceback. Adding check to to skip route checks bgp feature is disabled. On the Chassis supervisor, bgp may be disabled.
Signed-off-by: Anand Mehra [email protected]
What I did
Fixes sonic-net/sonic-buildimage#17400
Fixed the route_check.py traceback error on Chassis Supervisor.
How I did it
Added feature bgp check before performing frr route check. This prevents failure when bgp is not enabled on Supervisor.
How to verify it
run route_check.py on Supervisor. No traceback should be observed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Which release branch to backport (provide reason below if selected)