Fix to get all port related attributes from config_db #362

paavaanan · 2018-10-31T11:41:37Z

- What I did

interface_naming_mode functions fetch the alias_interface_name via sonic-cfggen. But, with the recent change in config_db removes all port related entries when a sepecific interface is down. This affects the existing implementation of fetching port details to following fucntions [ interface_alias_to_name(), interface_name_to_allias(), InterfaceAliasConverter() ] and throws key error.

- How I did it

To fix this, harnessed the existing port_config.ini file to fetch the interface details and populated a port_dict and this fetch the alias interface names quickly.

NOTE: config commands are entirely modified from linux commands to db format. This fix does not cover interface validation for those commands.

paavaanan · 2018-10-31T11:43:17Z

This fix address the issue
sonic-net/SONiC#268

config/main.py

show/main.py

config/main.py

stcheng · 2018-11-01T16:25:27Z

@paavaanan thanks for addresing the commits. could you also change the title of this pull request into a brief one? the current one contains some details that shall be moved into the commit message.

stcheng · 2018-11-04T21:39:07Z

@paavaanan this is a nice article about the git commit message: https://medium.com/@preslavrachev/what-s-with-the-50-72-rule-8a906f61f09c

config/main.py

show/main.py

paavaanan · 2018-11-08T12:29:14Z

@paavaanan this is a nice article about the git commit message: https://medium.com/@preslavrachev/what-s-with-the-50-72-rule-8a906f61f09c

Thanks shoutian

jleveque · 2018-11-08T19:46:38Z

config/main.py

+PLATFORM_ROOT_PATH = '/usr/share/sonic/device'
+SONIC_CFGGEN_PATH = '/usr/local/bin/sonic-cfggen'
+HWSKU_KEY = 'DEVICE_METADATA.localhost.hwsku'
+PLATFORM_KEY = 'DEVICE_METADATA.localhost.platform'


Why did you add definitions for PLATFORM_ROOT_PATH, HWSKU_KEY and PLATFORM_KEY? They are not used anywhere in the file.

Joe, it is added as part of the initiall pull request. This is not necessary. Will remove the lines

jleveque · 2018-11-08T19:48:40Z

config/main.py

@@ -12,17 +12,20 @@
 from swsssdk import ConfigDBConnector
 from natsort import natsorted
 from minigraph import parse_device_desc_xml
+from portconfig import get_port_config


Why add this import if you are not using it?

removed in the new commit

jleveque · 2018-11-08T19:50:08Z

show/main.py

+PLATFORM_ROOT_PATH = '/usr/share/sonic/device'
+SONIC_CFGGEN_PATH = '/usr/local/bin/sonic-cfggen'
+HWSKU_KEY = 'DEVICE_METADATA.localhost.hwsku'
+PLATFORM_KEY = 'DEVICE_METADATA.localhost.platform'


Why add these four constants? They are not used anywhere in the file.

Other than SONIC_CFGGEN_PATH removed unused constants

jleveque · 2018-11-08T19:50:33Z

show/main.py

@@ -15,9 +15,15 @@
 import sonic_platform
 from swsssdk import ConfigDBConnector
 from swsssdk import SonicV2Connector
+from portconfig import get_port_config


Why add this import if you are not using it?

removed in new commit

? This was not removed.

Addressed in new commit!

jleveque

As comments. Also, as Shuotian has requested, please abbreviate your PR title. It is a bit long. One place to start is to remove the opening [sonic-cfggen]: because this PR doesn't directly affect sonic-cfggen, which resides in the sonic-buildimage repo.

stcheng · 2018-11-12T22:15:56Z

thanks for fixing that!

Add support for attribute capability query in lua script (sonic-net#362)

EmmcUtil class implements SsdBase API and can be used by ssdutil instead of the default SsdUtil class on platforms that have eMMC. The class is copied from Arista platform. Signed-off-by: Yakiv Huryk <[email protected]>

interface_nameing_mode alias errors

78b6e69

paavaanan changed the title ~~interface_nameing_mode alias errors~~ KeyError: 'alias' when we try to use "show" command after shut / unshut the interface using config interface [InterfaceName] [shutdown | startup] Oct 31, 2018

stcheng suggested changes Nov 1, 2018

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

show/main.py Outdated Show resolved Hide resolved

show/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

stcheng added the Enhancement label Nov 1, 2018

removed sonic-cfgen dependency and config_db is used to query attributes

19e49c1

jleveque suggested changes Nov 5, 2018

View reviewed changes

config/main.py Show resolved Hide resolved

config/main.py Show resolved Hide resolved

show/main.py Show resolved Hide resolved

Included click.Abort() for graceful exit

26670e8

jleveque suggested changes Nov 8, 2018

View reviewed changes

Removing unused code

5035a05

jleveque suggested changes Nov 9, 2018

View reviewed changes

paavaanan changed the title ~~[sonic-cfggen]: Optimizing config/main.py to use config_db to fetch port related information and remove sonic-cfggen from the script.~~ Fix to get all port related attributes from config_db Nov 10, 2018

removing portconfig header module

91ca59e

jleveque approved these changes Nov 12, 2018

View reviewed changes

stcheng approved these changes Nov 12, 2018

View reviewed changes

jleveque merged commit ac67208 into sonic-net:master Nov 13, 2018

jleveque mentioned this pull request Nov 13, 2018

KeyError: 'alias' when we try to use "show" command after shut / unshut the interface using config interface [InterfaceName] [shutdown | startup] sonic-net/SONiC#268

Closed

stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022

[Submodule Update]

b3720bc

Add support for attribute capability query in lua script (sonic-net#362)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix to get all port related attributes from config_db #362

Fix to get all port related attributes from config_db #362

paavaanan commented Oct 31, 2018 •

edited

Loading

paavaanan commented Oct 31, 2018 •

edited

Loading

stcheng commented Nov 1, 2018

stcheng commented Nov 4, 2018

paavaanan commented Nov 8, 2018

jleveque Nov 8, 2018

paavaanan Nov 9, 2018

jleveque Nov 8, 2018

paavaanan Nov 9, 2018

jleveque Nov 8, 2018

paavaanan Nov 9, 2018

jleveque Nov 8, 2018

paavaanan Nov 9, 2018

jleveque Nov 9, 2018

paavaanan Nov 12, 2018

jleveque left a comment

stcheng commented Nov 12, 2018

Fix to get all port related attributes from config_db #362

Fix to get all port related attributes from config_db #362

Conversation

paavaanan commented Oct 31, 2018 • edited Loading

paavaanan commented Oct 31, 2018 • edited Loading

stcheng commented Nov 1, 2018

stcheng commented Nov 4, 2018

paavaanan commented Nov 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jleveque left a comment

Choose a reason for hiding this comment

stcheng commented Nov 12, 2018

paavaanan commented Oct 31, 2018 •

edited

Loading

paavaanan commented Oct 31, 2018 •

edited

Loading