Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portstat] fix header used #743

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Nov 18, 2019

Signed-off-by: Mykola Faryma [email protected]

Fixes #742
Looks like after the revert wrong header was used for the table.
- What I did

- How I did it

- How to verify it

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

Signed-off-by: Mykola Faryma <[email protected]>
jleveque
jleveque previously approved these changes Nov 18, 2019
@liat-grozovik
Copy link
Collaborator

retest this please

liat-grozovik
liat-grozovik previously approved these changes Nov 24, 2019
@liat-grozovik
Copy link
Collaborator

retest this please

2 similar comments
@liat-grozovik
Copy link
Collaborator

retest this please

@mykolaf
Copy link
Collaborator Author

mykolaf commented Dec 24, 2019

retest this please

@leoli-nps
Copy link

@mykolaf , The cntr.tx_err in lines 211 and 240 should be cntr.tx_ovr. Hope they can be modified together.

@mykolaf mykolaf dismissed stale reviews from liat-grozovik and jleveque via f4ce2c2 January 10, 2020 14:41
@mykolaf
Copy link
Collaborator Author

mykolaf commented Jan 10, 2020

@mykolaf , The cntr.tx_err in lines 211 and 240 should be cntr.tx_ovr. Hope they can be modified together.

@leoli-nps Thanks, updated.

@liat-grozovik liat-grozovik merged commit 3c09dcd into sonic-net:master Jan 14, 2020
abdosi pushed a commit that referenced this pull request Jan 21, 2020
* [portstat] fix header used

Signed-off-by: Mykola Faryma <[email protected]>

* [portstat] fix print table_as_json

Signed-off-by: Mykola Faryma <[email protected]>

* Fix tx_ovr field
@mykolaf mykolaf deleted the fix_header_portstat branch February 18, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portstat incorrect output
5 participants