-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[portstat] Fixed delete when no data saved #744
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokhan
previously approved these changes
Nov 19, 2019
vsenchyshyn
previously approved these changes
Nov 19, 2019
msosyak
changed the title
[porstat] Fixed delete when no data saved
[portstat] Fixed delete when no data saved
Nov 19, 2019
retest this please |
retest this please |
8 similar comments
retest this please |
retest this please |
retest this please |
retest this please |
retest this please |
retest this please |
retest this please |
retest this please |
msosyak
force-pushed
the
fix_delete_no_data
branch
from
January 20, 2020 14:01
e415077
to
0f5142e
Compare
retest this please |
msosyak
force-pushed
the
fix_delete_no_data
branch
from
March 29, 2022 12:25
0f5142e
to
89142af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added logic to avoid exception on delete when no data saved
- How I did it
Added isdir check before delete logic
- How to verify it
run portstat -D twice
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)