Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intfstat] fix --delete-all fail when counters dump does not exist #752

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Nov 22, 2019

Signed-off-by: Mykola Faryma [email protected]

Fixes #749

- What I did
Additional check for counter snapshot folder existance.
- How I did it

- How to verify it

  1. intfstat -D
  2. intfstat -D

- Previous command output (if the output of a command-line utility has changed)
Traceback (most recent call last):
File "/usr/bin/intfstat", line 346, in
main()
File "/usr/bin/intfstat", line 272, in main
for file in os.listdir(cnstat_dir):
OSError: [Errno 2] No such file or directory: '/tmp/intfstat-0'
- New command output (if the output of a command-line utility has changed)

@mykolaf mykolaf changed the title [intfstat] fix --delete fail when counters dump does not exist [intfstat] fix --delete-all fail when counters dump does not exist Nov 22, 2019
@liat-grozovik
Copy link
Collaborator

retest this please

2 similar comments
@liat-grozovik
Copy link
Collaborator

retest this please

@mykolaf
Copy link
Collaborator Author

mykolaf commented Dec 23, 2019

retest this please

@liat-grozovik liat-grozovik merged commit 6d0dee0 into sonic-net:master Dec 24, 2019
abdosi pushed a commit that referenced this pull request Jan 3, 2020
@mykolaf mykolaf deleted the intfstat_d branch February 18, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI command "intfstat -D" fails when counters dump file does not exist
3 participants