-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fwutil]: Command-line utility for interacting with platform components #772
Conversation
retest this please |
@sujinmkang please have a look. |
@lguohan please have a look. |
@mudsut4ke please have a look. |
retest this please |
4 similar comments
retest this please |
retest this please |
retest this please |
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing command reference update with the new commands.
@liat-grozovik: Do we want to add these commands to the Command Reference, or do we intend to wrap these commands in |
@liat-grozovik The CLI reference does not provide the description for the low level tools: |
a98bea4
to
7e81829
Compare
retest this please |
Please fix new conflicts. |
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
c3605aa
to
9e53117
Compare
Signed-off-by: Nazarii Hnydyn <[email protected]>
9e53117
to
bf81c6f
Compare
@jleveque done |
LGTM. @sujinmkang to review as well. |
@sujinmkang please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Merging is blocked because @liat-grozovik has an unresolved requested change. |
…ts (#772) * [fwutil]: initial version. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Fix UI: enable progressbar render finalizer. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: integrate utility with SONiC CLI. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: update CLI command reference documentation. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Revisit CLI architecture: avoid direct imports. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Fix review comments: refactor CLI command reference. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Fix review comments: update CLI documentation. Signed-off-by: Nazarii Hnydyn <[email protected]>
…ts (sonic-net#772) * [fwutil]: initial version. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Fix UI: enable progressbar render finalizer. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: integrate utility with SONiC CLI. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: update CLI command reference documentation. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Revisit CLI architecture: avoid direct imports. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Fix review comments: refactor CLI command reference. Signed-off-by: Nazarii Hnydyn <[email protected]> * [fwutil]: Fix review comments: update CLI documentation. Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn [email protected]
fwutil HLD: sonic-net/SONiC#463
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)