Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fwutil]: Fix firmware update command #895

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

nazariig
Copy link
Collaborator

Signed-off-by: Nazarii Hnydyn [email protected]

This PR contains a fix for fwutil update --image=next command: do not fail when current image contains invalid platform_component.json

- What I did

  • Fixed firmware update command

- How I did it

  • Changed ComponentUpdateProvider init order

- How to verify it

  1. fwutil update --image=current
  2. fwutil update --image=next

- Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# fwutil update --image=next
Error: Chassis component names mismatch: keys=['CPLD1', 'CPLD2', 'CPLD', 'CPLD3']. Aborting...
Aborted!

- New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# fwutil update --image=next
Chassis                  Module    Component    Firmware    Version                  Status      Info
-----------------------  --------  -----------  ----------  -----------------------  ----------  ------
x86_64-mlnx_msn3700c-r0  N/A       BIOS         N/A         0ACLH004_02.02.007_9600  up-to-date  N/A
                                   CPLD1        N/A         CPLD000120_REV0223       up-to-date  N/A
                                   CPLD2        N/A         CPLD000162_REV0800       up-to-date  N/A
                                   CPLD3        N/A         CPLD000106_REV0100       up-to-date  N/A
New firmware will be installed, continue? [y/N]: y

Summary:

Chassis                  Module    Component    Status
-----------------------  --------  -----------  ----------
x86_64-mlnx_msn3700c-r0  N/A       BIOS         up-to-date
                                   CPLD1        up-to-date
                                   CPLD2        up-to-date
                                   CPLD3        up-to-date

@jleveque jleveque merged commit a6de521 into sonic-net:master Apr 29, 2020
abdosi pushed a commit that referenced this pull request May 1, 2020
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
[fwutil]: Fix firmware update command. (sonic-net#895)
[utility] Filter FDB entries (sonic-net#890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants