Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved route_check tool and adopt to 20191130 image. #898

Merged
merged 3 commits into from
May 2, 2020

Conversation

renukamanavalan
Copy link
Contributor

  1. Add syslog support.
  2. Enable forever periodic scan
  3. Skip link local addresses
  4. Skip eth0 routes
  5. Adopt to 20191130 changes
    3.1) APPl-DB INTF_TABLE may not have IP address
    3.2) nexthop is never empty

- What I did

- How I did it

- How to verify it

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

1) Add syslog support.
2) Enable forever periodic scan
3) Skip link local addresses
4) Skip eth0 routes
3) Adopt to 20191130 changes
    3.1) APPl-DB INTF_TABLE may not have IP address
    3.2) nexthop is never empty
@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2020

This pull request fixes 1 alert when merging 61a7a7e into 3471926 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2020

This pull request fixes 1 alert when merging 172d9df into 3471926 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

…0' as local routes

2) Ensure to read route entry w/o prefix, if not present with prefix
@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2020

This pull request fixes 1 alert when merging 8267876 into e747456 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@renukamanavalan
Copy link
Contributor Author

lgtm says, I fixed an issue that was there in previous code.

@renukamanavalan renukamanavalan merged commit 44ed6e9 into sonic-net:master May 2, 2020
@lguohan
Copy link
Contributor

lguohan commented May 8, 2020

is this needed for 201811 image? does not seem to match the title of this pr

@yxieca
Copy link
Contributor

yxieca commented May 8, 2020

201811 branch is only taking bug fixes at this point.

rlhui pushed a commit that referenced this pull request May 10, 2020
* Changes:
1) Add syslog support.
2) Enable forever periodic scan
3) Skip link local addresses
4) Skip eth0 routes
3) Adopt to 20191130 changes
    3.1) APPl-DB INTF_TABLE may not have IP address
    3.2) nexthop is never empty

* No logical code change. A small name change.

* 1) Adopt to 201811 -- Filter out 'lo' & 'docker0' in addition to 'eth0' as local routes
2) Ensure to read route entry w/o prefix, if not present with prefix
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
* Changes:
1) Add syslog support.
2) Enable forever periodic scan
3) Skip link local addresses
4) Skip eth0 routes
3) Adopt to 20191130 changes
    3.1) APPl-DB INTF_TABLE may not have IP address
    3.2) nexthop is never empty

* No logical code change. A small name change.

* 1) Adopt to 201811 -- Filter out 'lo' & 'docker0' in addition to 'eth0' as local routes
2) Ensure to read route entry w/o prefix, if not present with prefix
@renukamanavalan renukamanavalan deleted the rt_chk_2019 branch September 3, 2020 17:39
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
[Vnet] Fix NameError for 'swsssdk' and align output (sonic-net#902)
[config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904)
Improved route_check tool and adopt to 20191130 image. (sonic-net#898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants