Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-wpasupplicant changes for PAC #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vijaya-ops
Copy link
Contributor

Why I did it

The PAC functionality uses radius client that is in wpa supplicant for both 802.1X and MAB. These changes are done to achieve the same.

How I did it

How to verify it

@vijaya-ops
Copy link
Contributor Author

Below are the associated PRs for this functionality.

#88
#89
#90
#91
sonic-net/sonic-utilities#3265
sonic-net/sonic-swss-common#871

HLD PR is below
sonic-net/SONiC#1655

we will raise the remaining functionality in new PRs asap.

@vijaya-ops
Copy link
Contributor Author

/azpw run Azure

@mssonicbld
Copy link

/AzurePipelines run Azure

Copy link

No pipelines are associated with this pull request.

@adyeung
Copy link

adyeung commented Aug 7, 2024

@jeff-yin @ridahanif96 pls help review

@vijaya-ops
Copy link
Contributor Author

/azpw run Azure

@mssonicbld
Copy link

/AzurePipelines run Azure

Copy link

No pipelines are associated with this pull request.

Copy link

@muhammadalihussnain muhammadalihussnain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Looks good to me.

Copy link

@muhammadalihussnain muhammadalihussnain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Looks good to me.

@@ -82,6 +85,9 @@ enum { RADIUS_ATTR_USER_NAME = 1,
RADIUS_ATTR_ACCT_OUTPUT_GIGAWORDS = 53,
RADIUS_ATTR_EVENT_TIMESTAMP = 55,
RADIUS_ATTR_EGRESS_VLANID = 56,
#ifdef CONFIG_SONIC_RADIUS
Copy link

@venkatmahalingam venkatmahalingam Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be in the middle? can't we move all new enums at the end?

@@ -1728,3 +1751,420 @@ int radius_gen_session_id(u8 *id, size_t len)
*/
return os_get_random(id, len);
}

#ifdef CONFIG_SONIC_RADIUS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this SONiC specific code changes be moved to new file or patch file?

@adyeung
Copy link

adyeung commented Oct 1, 2024

@Pterosaur code PR has been approved by PENS WG members, pls help merge

@@ -124,7 +133,11 @@ enum { RADIUS_ATTR_USER_NAME = 1,
#define RADIUS_TERMINATION_ACTION_RADIUS_REQUEST 1

/* NAS-Port-Type */
#ifdef CONFIG_SONIC_RADIUS
#define RADIUS_NAS_PORT_TYPE_IEEE_802_11 15
Copy link

@praveenraja1 praveenraja1 Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IEEE 802.11 standard wireless interface has NAS port type as 19, and for "Ethernet" interface its 15, can we have the below instead "ifdef -else" block"

#ifdef CONFIG_SONIC_RADIUS
#define RADIUS_NAS_PORT_TYPE_ETHERNET 15
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants