Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable onnx tests on Windows, until they can be fixed. #174

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Disable onnx tests on Windows, until they can be fixed. #174

merged 1 commit into from
Sep 30, 2019

Conversation

hrydgard
Copy link
Contributor

Allows you to do a plain cargo build in the base directory.

Allows you to do a plain cargo build in the base directory.
@kali
Copy link
Collaborator

kali commented Sep 30, 2019

Is this the only sub project in harness that blocks the build under windows ? The other are ok ?

@hrydgard
Copy link
Contributor Author

hrydgard commented Sep 30, 2019

It appears so from testing I did this morning. Currently can't build due to the protobuf issue so hard to confirm.

@kali kali merged commit 3ec9c50 into sonos:master Sep 30, 2019
@kali
Copy link
Collaborator

kali commented Sep 30, 2019

All right thanks, I will change the CI scripts accordingly.

@hrydgard hrydgard deleted the disable-onnx-tests-on-windows branch September 30, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants