fix: make scope optional and don't send it if undefined #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests don't seem to work on my machine (two of them fail on main), so I think I'll ask that you address them, @soofstad 😄 |
LucasFrecia
approved these changes
Jun 14, 2023
soofstad
force-pushed
the
fix/hide-scope-if-undefined
branch
from
1772210
to
51f19be
Compare
soofstad
force-pushed
the
fix/hide-scope-if-undefined
branch
from
51f19be
to
59f0cb7
Compare
soofstad
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Makes the
scopeproperty internally optional as well (optional = allowed to beundefined). Also hides it from requests if it's set toundefined, as per the spec.Why is this pull request needed?
We didn't adhere to the spec. Now we do (more closely at least).
Issues related to this change
Closes #96.