transform js files only, preventing conflicts with other input source files #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how would this affect, say, |
|
I don't use jsx but I suspect that with this change the es3ify transform will not be applied to jsx files. It will change the current behavior of es3ify. To prevent this we could test also the jsx extension by default, or/and add an "extensions" option like babelify and many other transforms does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently es3ify check the file name to filter JSON file (as it can't and should not transform them).
I assume this was done to fix browserify crashes with this transform. But it dit not resolve the issue for other input files.
es3ify should try to transform javascript file only, so a more permanent fix seems to ignore anything else