Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go runtime to 1.19 #43

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Upgrade go runtime to 1.19 #43

merged 2 commits into from
Aug 31, 2022

Conversation

moznion
Copy link
Contributor

@moznion moznion commented Aug 31, 2022

No description provided.

@moznion moznion requested a review from 0x6b August 31, 2022 00:08
@moznion moznion self-assigned this Aug 31, 2022
@moznion
Copy link
Contributor Author

moznion commented Aug 31, 2022

oops, golangci-lint warns errors...

@0x6b
Copy link
Collaborator

0x6b commented Aug 31, 2022 •
edited
Loading

@moznion Thanks again for the update! Now golangci-lint warnings went away, thanks to commits from #42. Will make further review later.

0x6b
0x6b approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@0x6b 0x6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@0x6b 0x6b merged commit 2cb5d63 into main Aug 31, 2022
@0x6b 0x6b deleted the go1.19 branch August 31, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x6b 0x6b 0x6b approved these changes

Assignees

@moznion moznion

Labels
dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moznion @0x6b