Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update various dependencies #56

Merged
merged 8 commits into from
Sep 5, 2023
Merged

deps: update various dependencies #56

merged 8 commits into from
Sep 5, 2023

Conversation

0x6b
Copy link
Collaborator

@0x6b 0x6b commented Sep 5, 2023

Will tag it as v1.2.6 once I get approval.

Closes: #46 #50 #53 #54

- Extracted version numbers as environment variables in order to make obsolete version easily findable.
- Install mockgen, which is used while building, explicitly
- Update dependencies
    - golangci-lint 1.54.2 from 1.52.2
    - goimports: 0.12.0 from 0.1.4
@0x6b 0x6b self-assigned this Sep 5, 2023
@0x6b 0x6b marked this pull request as ready for review September 5, 2023 10:30
@0x6b 0x6b requested a review from moznion September 5, 2023 10:30
@0x6b 0x6b marked this pull request as draft September 5, 2023 10:42
@0x6b
Copy link
Collaborator Author

0x6b commented Sep 5, 2023

Back to draft status as we got /__w/_temp/0ad62771-86eb-4485-89d6-0fe3f771f040.sh: line 1: make: not found error while running test with updated container image.

https://github.com/soracom/soratun/actions/runs/6083326798/job/16503424618#step:5:5

- make: remove error while running test

```
/__w/_temp/0ad62771-86eb-4485-89d6-0fe3f771f040.sh: line 1: make: not found
```

- tar: remove warnings while running golangci-lint
@0x6b
Copy link
Collaborator Author

0x6b commented Sep 5, 2023

4d2469f solved the testing issue. Make it ready for review.

@0x6b 0x6b marked this pull request as ready for review September 5, 2023 11:07
Copy link
Contributor

@moznion moznion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems nice, thanks.

@moznion moznion merged commit 2b1519b into main Sep 5, 2023
1 check passed
@moznion moznion deleted the update-deps branch September 5, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants