Remove double click action on cell #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was a source of confusion for new pgweb users for quite some time now. Most people thought by double-clicking the cell it would allow them to edit the value since the column is replaced with textarea. The textarea was there to copy the cell's value, not for editing. Feature is no longer required due to availability of a cell context menu, which provides a link to copy the value.
|
@sosedoff following this change how do you recommend viewing the full contents of a long text field? Thanks for your work 🙂 |
|
@Tom-Fawcett you can right-click on the cell and copy the value using context menu. |
|
@sosedoff so for a long value I'd need to copy and paste it somewhere else to view it fully? Thanks |
|
Something like that yea. Im all ears if you have suggestions for this feature, i just dont use it often so havent really implemented a replacement. The old flow confused a lot of people so i removed it. |
|
An integrated way to view fully would be useful 🙂 E.g
|
|
A popup makes more sense to me here |
|
I've raised #633 as a suggestion 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the confusing behavior when double clicking on the cell. Textarea was for copying data and not for editing like most people assumed.