Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing indexes by quoting schema/table name to ::regclass #711

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix missing indexes by quoting schema/table name to ::regclass #711

merged 1 commit into from
Mar 12, 2024

Conversation

ashkulz
Copy link
Contributor

@ashkulz ashkulz commented Feb 7, 2024

The same approach is used in pkg/statements/sql/table_schema.sql and a sample reproduction for the bug is:

CREATE SCHEMA test;
CREATE TABLE test.data (id INTEGER PRIMARY KEY, name TEXT);
CREATE UNIQUE INDEX "test.data_uniq" ON test.data (name);

Only the primary key is shown, and not the index created above.

The same approach is used in pkg/statements/sql/table_schema.sql
and a sample reproduction for the bug is:

  CREATE SCHEMA test;
  CREATE TABLE test.data (id INTEGER PRIMARY KEY, name TEXT);
  CREATE UNIQUE INDEX "test.data_uniq" ON test.data (name);

Only the primary key is shown, and not the index created above.
@sosedoff sosedoff merged commit 8a8b9f0 into sosedoff:master Mar 12, 2024
11 checks passed
@sosedoff
Copy link
Owner

Thanks for the bugfix!

@ashkulz ashkulz deleted the fix_index_display branch March 12, 2024 04:55
@ashkulz
Copy link
Contributor Author

ashkulz commented Mar 12, 2024

Any ETA for a release? If there's none, I'd appreciate a response to this comment so I can work on it and have both included in the next release 🙂

@sosedoff
Copy link
Owner

I dont have a particular schedule for releases, and usually try to get at least a few PRs (fixes/minor improvements) in before cutting a new version. Maybe a few weeks? maybe less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants